Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct dialog product features in MiqAeCustomizationController #5197

Conversation

lpichler
Copy link
Contributor

@lpichler lpichler commented Jan 25, 2019

dialog_new_editor and dialog_edit_editor are correct permissions for service dialogs (added ManageIQ/manageiq#15418):

Automation -> Automate -> Customization -> Service Dialogs

screenshot 2019-01-25 at 12 01 40

cc @skateman

Links

https://bugzilla.redhat.com/show_bug.cgi?id=1297415
caused by ManageIQ/manageiq#15418 and ManageIQ/manageiq#17550

Also https://bugzilla.redhat.com/show_bug.cgi?id=1677724

@lpichler
Copy link
Contributor Author

@miq-bot assign @mzazrivec

@miq-bot
Copy link
Member

miq-bot commented Jan 25, 2019

Checked commit lpichler@023cd0d with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. ⭐

@mzazrivec mzazrivec added this to the Sprint 104 Ending Feb 04, 2019 milestone Jan 25, 2019
@mzazrivec mzazrivec merged commit 73a2a68 into ManageIQ:master Jan 25, 2019
@lpichler lpichler deleted the use_correct_product_features_to_access_dialog_new_edit_actions branch January 25, 2019 13:50
simaishi pushed a commit that referenced this pull request Feb 18, 2019
…o_access_dialog_new_edit_actions

Use correct dialog product features in MiqAeCustomizationController

(cherry picked from commit 73a2a68)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1678449
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1678450
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit ea8a589dd463614cbf6809676e1ac8d86ac0a761
Author: Milan Zázrivec <[email protected]>
Date:   Fri Jan 25 12:27:17 2019 +0100

    Merge pull request #5197 from lpichler/use_correct_product_features_to_access_dialog_new_edit_actions
    
    Use correct dialog product features in MiqAeCustomizationController
    
    (cherry picked from commit 73a2a68d17e840b8aad9cfaaf203c9ee98a3cfe5)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1678449
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1678450

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants