Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes breadcrumb when disabling/enabling schedules #5422

Merged
merged 1 commit into from
Apr 5, 2019
Merged

Fixes breadcrumb when disabling/enabling schedules #5422

merged 1 commit into from
Apr 5, 2019

Conversation

rvsia
Copy link
Contributor

@rvsia rvsia commented Apr 3, 2019 •
edited
Loading

Fixes #5375

  1. Configuration ➛ Settings ➛ Schedules
  2. Select a schedule from the list view
  3. Configuration ➛ Enable / Disable this schedule
  4. See the messed up breadcrumbs

Description

  • replaces the breadcrumbs condition to recognize when mixin is in explorer controller (after enabling/disabling the mixin is confused and thinks it is in a not-explorer controller)
  • features should always define if the controller is explorer/not-explorer
  • plus clears @sb[:action] when tree_select in ops_controller
  • plus clearing specs of removed show_list_title option
  • plus checks if @right_cell_text and accord_title exist before calling them

Before

bc01

After

image

@miq-bot add_label bug, hammer/no

@rvsia rvsia changed the title Fixes breadcrumb when disabling/enabling schedules [WIP] Fixes breadcrumb when disabling/enabling schedules Apr 3, 2019
@miq-bot miq-bot added the wip label Apr 3, 2019
@rvsia rvsia force-pushed the fix-ops-breadcrumbs branch from 32d2790 to 5df028f Compare April 3, 2019 15:29
@rvsia rvsia changed the title [WIP] Fixes breadcrumb when disabling/enabling schedules Fixes breadcrumb when disabling/enabling schedules Apr 3, 2019
@miq-bot miq-bot removed the wip label Apr 3, 2019
@rvsia rvsia changed the title Fixes breadcrumb when disabling/enabling schedules [WIP] Fixes breadcrumb when disabling/enabling schedules Apr 4, 2019
@miq-bot miq-bot added the wip label Apr 4, 2019
@rvsia rvsia force-pushed the fix-ops-breadcrumbs branch from 5df028f to e5235d1 Compare April 4, 2019 17:40
@rvsia
Fixes breadcrumb when disabling/enabling schedules
da98053 
* replace the condition to recognize when mixin is in explorer controller, after enabling/disabling the mixin is confused and thinks is in a not-explorer controller
* features? should always define if the controller is explorer/not-explorer
* plus clears @sb[:action] when tree_select in ops_controller
@rvsia rvsia force-pushed the fix-ops-breadcrumbs branch from e5235d1 to da98053 Compare April 4, 2019 17:48
@miq-bot
Copy link
Member

miq-bot commented Apr 4, 2019

Checked commit rvsia@da98053 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
5 files checked, 0 offenses detected
Everything looks fine. 🍪

@rvsia rvsia changed the title [WIP] Fixes breadcrumb when disabling/enabling schedules Fixes breadcrumb when disabling/enabling schedules Apr 4, 2019
@rvsia rvsia mentioned this pull request Apr 4, 2019
Merged
@miq-bot miq-bot removed the wip label Apr 4, 2019
@mzazrivec mzazrivec self-assigned this Apr 5, 2019
@mzazrivec mzazrivec added this to the Sprint 109 Ending Apr 15, 2019 milestone Apr 5, 2019
@mzazrivec mzazrivec merged commit cc0337d into ManageIQ:master Apr 5, 2019
@rvsia rvsia deleted the fix-ops-breadcrumbs branch April 5, 2019 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzazrivec mzazrivec mzazrivec approved these changes

Assignees

@mzazrivec mzazrivec

Labels
breadcrumbs bug hammer/no settings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Messed up breadcrumbs when enabling / disabling schedule
4 participants
@rvsia @miq-bot @mzazrivec @martinpovolny