Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add formatting to report data filter display. #5928

Merged
merged 1 commit into from
Aug 5, 2019
Merged

Add formatting to report data filter display. #5928

merged 1 commit into from
Aug 5, 2019

Conversation

martinpovolny
Copy link
Member

Add styling to report data filter display.

After:
report-style-2019-08-02_11-19

Requires: ManageIQ/manageiq#18938 (merged)

@martinpovolny martinpovolny force-pushed the report_table_formatting branch from 148ca92 to ec6ac1b Compare August 2, 2019 09:31
@miq-bot
Copy link
Member

miq-bot commented Aug 2, 2019

Checked commit martinpovolny@ec6ac1b with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@martinpovolny
Copy link
Member Author

@lpichler : pls, test?
@mzazrivec : review?

@martinpovolny martinpovolny requested a review from mzazrivec August 2, 2019 13:23
lpichler
lpichler approved these changes Aug 5, 2019
View reviewed changes
Copy link
Contributor

@lpichler lpichler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and it works 👍 thanks

@mzazrivec mzazrivec self-assigned this Aug 5, 2019
@mzazrivec mzazrivec added this to the Sprint 117 Ending Aug 5, 2019 milestone Aug 5, 2019
@mzazrivec mzazrivec merged commit b287dc4 into ManageIQ:master Aug 5, 2019
simaishi pushed a commit that referenced this pull request Aug 5, 2019
@mzazrivec @simaishi
Merge pull request #5928 from martinpovolny/report_table_formatting
396c68c 
Add formatting to report data filter display.

(cherry picked from commit b287dc4)
@simaishi
Copy link
Contributor

simaishi commented Aug 5, 2019

Ivanchuk backport details:

$ git log -1
commit 396c68ce8c10ddac3117f749cda0c448c4391a5c
Author: Milan Zázrivec <[email protected]>
Date:   Mon Aug 5 11:41:28 2019 +0200

    Merge pull request #5928 from martinpovolny/report_table_formatting
    
    Add formatting to report data filter display.
    
    (cherry picked from commit b287dc49732f5fc7bce9e01535ede6a0515cd0a7)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpichler lpichler lpichler approved these changes

@mzazrivec mzazrivec mzazrivec approved these changes

Assignees

@mzazrivec mzazrivec

Labels
enhancement ivanchuk/backported overview/reporting react
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@martinpovolny @miq-bot @simaishi @mzazrivec @lpichler