-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Back button to policy simulation page for non-explorer #6099
Add Back button to policy simulation page for non-explorer #6099
Conversation
@miq-bot add_label bug, ivanchuk/yes, changelog/yes |
2d3d6e0
to
c76b7ed
Compare
c76b7ed
to
663761c
Compare
Checked commit hstastna@663761c with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
@hstastna is this a regression? Because I think this thing used to work some time ago and we might have to look into what caused the problem than adding a new button. cc @h-kataria |
I think this is not a regression but I may be wrong. I will try to check this in older versions. |
Update: reporter of the bug cannot test if this is a regression due to https://bugzilla.redhat.com/show_bug.cgi?id=1686619 in 5.9 and also 5.10. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1704395
Back button was missing in policy simulation screen while checking details of selected item. This is related only to non-explorer screens, for example for list of VMs displayed thru provider's details page. For explorer ones, the button was there (see this).
I am also adding another change
session[:edit] = @edit
. First,@edit
with details of policy simulation is set inpolicy_sim_build_screen
method and then forgotten, for non-explorer screens. This caused problems with rendering the selected item's info later, also with clicking on a selected item (quadicon).session[:edit] = @edit
needs to be set afterpolicy_sim_build_screen
is called.The fix works also for nested list of Instances.
After: