Correctly catch & handle API errors when creating orchestration template #6116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit mzazrivec@bd3001d with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
mzazrivec
deleted the
correctly_catch_api_errors_when_creating_and_updating_ot
branch
simaishi
pushed a commit
that referenced
this pull request
Oct 31, 2019
…en_creating_and_updating_ot Correctly catch & handle API errors when creating orchestration template (cherry picked from commit cf1aa2a) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1767648
|
Ivanchuk backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this fix, a modal window showing an odd looking api error would be shown.
With this fix, a nice flash message with an error is rendered.
https://bugzilla.redhat.com/show_bug.cgi?id=1745884