Use copy_params_if_present in cloud network/subnet and floating ip controllers #6139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@romanblanco What do you think about these changes? Thanks! :) |
hstastna
force-pushed
the
Networks_copy_params_present
branch
from
43cf0fc to
cd28fec
Compare
romanblanco
reviewed
Sep 2, 2019
| @@ -223,17 +223,12 @@ def form_params | |||
| # Admin_state_Up is true by default | |||
| params[:enabled] = false unless params[:enabled] | |||
|
|
|||
| options[:name] = params[:name] if params[:name] | |||
| options[:ems_id] = params[:ems_id] if params[:ems_id] | |||
| copy_params_if_present(options, params, %i[name ems_id qos_policy_id provider_network_type provider_physical_network provider_segmentation_id]) | |||
| options[:admin_state_up] = switch_to_bol(params[:enabled]) | |||
| options[:shared] = switch_to_bol(params[:shared]) | |||
| options[:external_facing] = switch_to_bol(params[:external_facing]) | |||
| # TODO: uncomment once form contains this field | |||
| # options[:port_security_enabled] = params[:port_security_enabled] if params[:port_security_enabled] | |||
There was a problem hiding this comment.
I feel like you can also remove the commented lines, as they are 3 years old now
|
Checked commit hstastna@cd28fec with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
This was referenced Sep 4, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #6105
We can use new
copy_params_if_presentmethod in many places in the code and to improve functionality (remove""vsnilissues and bad response ofAdd/Savebuttons), to simplify the code.Related PRs/changes:
#5815
d3c3878#diff-956e46b33fb5307990c4e1a4b5fd86ccR1267