Use copy_params_if_present in vm_common, manager_controller_mixin and miq_request_methods #6152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: ManageIQ#6105 Use the new method also in miq_request_methods.rb
|
@miq-bot add_label technical debt |
|
@miq-bot add_reviewer @romanblanco |
|
@hstastna 'romanblanco mzazrivec' is an invalid reviewer, ignoring... |
|
Checked commit hstastna@2098401 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #6105
We can use
copy_params_if_presentmethod in some more places/controllers and to improve functionality (remove""vsnilissues and bad response of Add/Save buttons) or to simplify the code.Related PRs/changes:
#6139
#5815
d3c3878#diff-956e46b33fb5307990c4e1a4b5fd86ccR1267