Fix error on Cloud Provider Dashboard

[bmclaughlin]

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1632750

[bmclaughlin]

@miq-bot add_label bug, compute/cloud

[martinpovolny]

Maybe a bit of refactoring to show the intent. Something like:

  def format_data(resource, attributes, attr_icon, attr_url, attr_hsh)
    attributes.reject { |a| @ems.send(a).nil? }.map do |attr|
      {
        :id        => "#{attr_hsh[attr]}_#{@ems_id}",
        :iconClass => attr_icon[attr],
        :title     => attr_hsh[attr],
        :count     => @ems.send(attr).count,
        :href      => get_url(resource, @ems_id, attr_url[attr]),
      }
    end
  end

May be better?

Plus there surely should be a test for this.

Thx!

[bmclaughlin]

@martinpovolny, Good idea with the refactoring, definitely more understandable. That update and a test will be coming soon. Thanks!

[miq-bot]

Checked commits bmclaughlin/manageiq-ui-classic@aaf3b54~...ae8da7f with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍰

[bmclaughlin]

@martinpovolny, refactored and tested.