Dialog sample - fix render dropdowns #6630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automation > Automate > Customization > Service Dialogs, click a dialog, see right-side detail before, if the dialog only has dynamic dropdowns, or only required non-dynamic dropdowns, no dropdown would get shown. That's because they already have the .selectpicker class which hides the %select element, but the call to miqInitSelectPicker never happened outside the non-dynamic non-required branch, never rendering the selectpicker component. now, all selects (including tags) should render in each case, with :multiple correctly set. Fixes #5279
|
dialog with all kinds of non-dynamic dropdowns before:
now:
|
|
dialog "Transform VM" (hardcoded) before:
now:
|
|
Checked commit https://github.com/himdel/manageiq-ui-classic/commit/687ba0658a7c26210ca3c81ac8422d9e2a5933b4 with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
mzazrivec
approved these changes
Jan 24, 2020
simaishi
pushed a commit
that referenced
this pull request
Apr 7, 2020
Dialog sample - fix render dropdowns (cherry picked from commit 447c063) https://bugzilla.redhat.com/show_bug.cgi?id=1801862
|
Ivanchuk backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automation > Automate > Customization > Service Dialogs,
click a dialog, see right-side detail
before, if the dialog only has dynamic dropdowns, or only required non-dynamic dropdowns, no dropdown would get shown.
That's because they already have the .selectpicker class which hides the %select element, but the call to miqInitSelectPicker never happened outside the non-dynamic non-required branch, never rendering the selectpicker component.
now, all selects (including tags) should render in each case, with :multiple correctly set.
Fixes #5279
Cc @d-m-u