Modify label_tag_mapping_add to accommodate scoped entity type.

[djberg96]

This PR is based on the changes in ManageIQ/manageiq#14288. In that PR the mappable types are scoped by provider, e.g. "Amazon::Vm" or "Kubernetes::ContainerNode".

Instead of automatically using the hard coded AUTOTAG_PREFIX, it parses the provider name from the selected item if possible. The AUTOTAG_PREFIX is still the default value, which preserves backwards compatibility.

[cben]

cc @zgalor See also core PR ManageIQ/manageiq#14288 for context.

[cben]

Consider just having lowercase prefixes in MAPPABLE_ENTITIES.
Capitalized with :: looks like provider class name, but it's not exactly, IMO more confusing then helpful.

But then you might need upcase to display as "Amazon/Vm" in UI? BTW, will we want translation of Amazon.
BTW, your screenshot shows "Amazon/Vm" with slash, where does :: -> / replacement happen?

[cben]

This method was already too long, please extract a method to compute category name (or some other split).

[cben]

4 ems_container_controller_spec, container_node_controller_spec failures unrelated, fixed on ui-classic master.
2 label_tag_mapping_spec failures relevant of course.

[djberg96]

@cben, Yeah, the UI depends on the MAPPABLE_ENTITIES, so I didn't want to downcase those. I'm not sure where the "/" to "::" conversion happens right off. I remember seeing it somewhere buried in the code, but it's definitely what I saw in the logs.

I've refactored the method a bit and added some custom specs. I'm not sure what Rubocop is whining about exactly.

[djberg96]

@miq-bot remove_label wip

[djberg96]

@blomquisg Ok, ready to go.

[blomquisg]

ManageIQ/manageiq#14288 is merged now.

[blomquisg]

@miq-bot assign dclarizio

[blomquisg]

@miq-bot add_label enhancement, cloud/compute

[miq-bot]

@blomquisg Cannot apply the following label because they are not recognized: cloud/compute

[blomquisg]

@miq-bot add_label compute/cloud

[blomquisg]

@miq-bot remove_label "pending core"

[miq-bot]

@blomquisg Cannot remove the following label because they are not recognized: "pending core"

[blomquisg]

@miq-bot remove_label pending core

[djberg96]

@dclarizio @AparnaKarve Look alright? Can we merge?

[AparnaKarve]

@djberg96 Tested successfully in the UI.

Other than the PR #, LGTM :)

[dclarizio]

@AparnaKarve I see "container" on a lot of those screens, can you comment on what else needs to be changed? Thx, Dan

[AparnaKarve]

I see "container" on a lot of those screens, can you comment on what else needs to be changed?

@dclarizio Good point.

@djberg96 So looks like this is not applicable to Containers alone anymore, the entity could also be Amazon now.

To keep it more generic we could just lose the Containers word in the haml.
More like --
Choose an entity and label in the first screenshot, and
Entity and Label in the table in the second screenshot

screenshot#1

screenshot#2

[djberg96]

@AparnaKarve @dclarizio ~~~Yes, those should be reworked but I would like to save it for a future PR. In the next iteration, the plan is to add another selection field (provider). Can that wait until then?~~~ Nevermind, I guess it's just a few text updates, I'll update the PR.

[miq-bot]

Checked commits https://github.com/djberg96/manageiq-ui-classic/compare/8bc11ee9b973f723350f3fb527a00855faa97bea~...c298c141381f15d2dd5c4185d33a00b17ee9e5f3 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
3 files checked, 10 offenses detected

app/controllers/ops_controller/settings/label_tag_mapping.rb

• ❗ - Line 140, Col 38 - Style/IfInsideElse - Convert if nested inside else to elsif.

spec/controllers/ops_controller/settings/label_tag_mapping_spec.rb

• ❗ - Line 102, Col 7 - Rails/HttpPositionalArguments - Use keyword arguments instead of positional arguments for http call: post.
• ❗ - Line 20, Col 7 - Rails/HttpPositionalArguments - Use keyword arguments instead of positional arguments for http call: post.
• ❗ - Line 21, Col 7 - Rails/HttpPositionalArguments - Use keyword arguments instead of positional arguments for http call: post.
• ❗ - Line 22, Col 7 - Rails/HttpPositionalArguments - Use keyword arguments instead of positional arguments for http call: post.
• ❗ - Line 23, Col 7 - Rails/HttpPositionalArguments - Use keyword arguments instead of positional arguments for http call: post.
• ❗ - Line 81, Col 7 - Rails/HttpPositionalArguments - Use keyword arguments instead of positional arguments for http call: post.
• ❗ - Line 86, Col 7 - Rails/HttpPositionalArguments - Use keyword arguments instead of positional arguments for http call: post.
• ❗ - Line 91, Col 7 - Rails/HttpPositionalArguments - Use keyword arguments instead of positional arguments for http call: post.
• ❗ - Line 96, Col 7 - Rails/HttpPositionalArguments - Use keyword arguments instead of positional arguments for http call: post.