Fixed undefined method `each' for nil:NilClass error on retirement tab #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that retirement hash is returned with remove_resources value, had to add checks around extra_vars loops to fix undefined method `each' for nil:NilClass error. And also only show Dialog name/link if dialog was selected on retirement tab.
|
Checked commit h-kataria@0c890d1 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 app/views/catalog/_sandt_tree_show.html.haml
|
|
@tinaafitz Please review. |
|
@h-kataria Looks good. |
|
@martinpovolny @mzazrivec please merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that retirement hash is returned with remove_resources value, had to add checks around extra_vars loops to fix undefined method `each' for nil:NilClass error. And also only show Dialog name/link if dialog was selected on retirement tab.
@gmcculloug please review, i was seeing this error while accessing catalog item that i had save Remove Resources value for.