Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing main_div - fixed functions on hosts comparison #775

Merged
merged 1 commit into from
Mar 24, 2017

Conversation

jzigmund
Copy link

@jzigmund jzigmund commented Mar 23, 2017

#As I worked on #773 I noticed not working delete column, in web console saw error missing main_div there.

https://bugzilla.redhat.com/show_bug.cgi?id=1428946

@jzigmund
Copy link
Author

jzigmund commented Mar 23, 2017

as @skateman noticed - it's also fixing #415

@h-kataria
Copy link
Contributor

@jzigmund i think there is also a BZ opened on the Host compare screen issue. I believe this one in @martinpovolny queue https://bugzilla.redhat.com/show_bug.cgi?id=1428946 Can you please verify this PR fixes the BZ and add link in the commit.

@jzigmund jzigmund force-pushed the fix_hosts_comparison branch from 4c08bf1 to 3541d83 Compare March 24, 2017 13:19
@jzigmund
Copy link
Author

@h-kataria yea thanks to pointing on the BZ, and yes it's fixing the bug, updated PR commit message with the BZ link

@miq-bot
Copy link
Member

miq-bot commented Mar 24, 2017

Checked commit jzigmund@3541d83 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks good. 🍪

@h-kataria h-kataria added this to the Sprint 57 Ending Mar 27, 2017 milestone Mar 24, 2017
@h-kataria h-kataria merged commit c2e8df2 into ManageIQ:master Mar 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants