Fix filters in config mgmt Configured systems #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label bug, ui |
|
@hstastna Cannot apply the following label because they are not recognized: ui |
hstastna
force-pushed
the
Config_mgmt_configured_systems
branch
from
c1cf869 to
d214039
Compare
mzazrivec
suggested changes
Mar 29, 2017
| builder = TreeBuilder.class_for_type(tree_type) | ||
| tree = builder.new(x_active_tree, tree_type, @sb) | ||
| end | ||
| if "configuration_manager_cs_filter_tree" == x_active_tree.to_s |
There was a problem hiding this comment.
I know this has been there before, but I'd much rather see:
if x_active_tree.to_s == "configuration_manager_cs_filter_tree"| @@ -450,7 +450,7 @@ def adv_search_button | |||
| if ["delete", "saveit"].include?(params[:button]) | |||
| if @edit[:in_explorer] || x_active_tree == :storage_tree | |||
| tree_name = x_active_tree.to_s | |||
| if "configuration_manager_cs_filter_tree_tree" == tree_name | |||
| if "configuration_manager_cs_filter_tree" == tree_name | |||
hstastna
force-pushed
the
Config_mgmt_configured_systems
branch
from
d214039 to
331b07d
Compare
|
For some reason, when I click on the created filter, I get this error: |
hstastna
force-pushed
the
Config_mgmt_configured_systems
branch
from
331b07d to
345bc68
Compare
hstastna
changed the title
hstastna
force-pushed
the
Config_mgmt_configured_systems
branch
from
345bc68 to
4aeafdb
Compare
hstastna
force-pushed
the
Config_mgmt_configured_systems
branch
from
4aeafdb to
8750f10
Compare
|
@mzazrivec I have rebased and repushed this PR and before that I have tested my changes again and using different databases and for me it all works perfectly all the time. Do you still get the error? |
|
This pull request is not mergeable. Please rebase and repush. |
hstastna
force-pushed
the
Config_mgmt_configured_systems
branch
3 times, most recently
from
e606162 to
bc4a4bc
Compare
hstastna
force-pushed
the
Config_mgmt_configured_systems
branch
2 times, most recently
from
908afb0 to
a8f850f
Compare
|
I see the problem I reported above still present:
|
added 3 commits
May 31, 2017 14:00
fixing https://bugzilla.redhat.com/show_bug.cgi?id=1429519 Fix saving a new filter in expression editor in Configuration -> Management -> Configured systems and enable displaying flash message about successful saving. Fix disappearing tree view after saving a filter. Enable displaying name of a filter under Global/My Filters in tree view.
fixing https://bugzilla.redhat.com/show_bug.cgi?id=1429519 Fix applying selected filter from Global/My Filters in accordion when clicking on the name of a filter in Configuration -> Management -> Configured systems. Fix disappearing of tree view when deleting loaded filter in expression editor.
fixing https://bugzilla.redhat.com/show_bug.cgi?id=1429519 Fix error which occured after selecting a filter from Global/My Filters in accordion when clicking on the name of a filter in Configuration -> Management -> Configured systems because of wrong id format which had to be uncompressed before using in listnav_search_selected method.
hstastna
force-pushed
the
Config_mgmt_configured_systems
branch
from
a8f850f to
3ae3b9c
Compare
|
@mzazrivec I added another commit to this PR to fix the error you have mentioned. Now it works well. |
|
Checked commits hstastna/manageiq-ui-classic@531ac1a~...3ae3b9c with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
simaishi
pushed a commit
that referenced
this pull request
Jun 12, 2017
Fix filters in config mgmt Configured systems (cherry picked from commit 96631ab) https://bugzilla.redhat.com/show_bug.cgi?id=1460792
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing https://bugzilla.redhat.com/show_bug.cgi?id=1429519
Fix saving a new filter in expression editor
in Configuration -> Management -> Configured systems
and enable displaying flash message about successful saving.
Fix disappearing tree view after saving a filter.
Enable displaying name of a filter under Global/My Filters
in tree view.
Fix applying selected filter from Global/My Filters
in accordion when clicking on the name of a filter.
Fix disappearing of tree view when deleting loaded
filter in expression editor.
Before:
After:
