Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spec for url sorting in the automation providers list #828

Merged
merged 1 commit into from
Apr 13, 2017
Merged

Spec for url sorting in the automation providers list #828

merged 1 commit into from
Apr 13, 2017

Conversation

lgalis
Copy link
Contributor

@lgalis lgalis commented Mar 28, 2017 •
edited
Loading

Spec for url sorting in the automation providers list.
Dependent on ManageIQ/manageiq#14184

Specs for https://bugzilla.redhat.com/show_bug.cgi?id=1434915

@lgalis lgalis changed the title Spec for url sorting in the automation providers list [WIP]Spec for url sorting in the automation providers list Mar 28, 2017
@miq-bot miq-bot added the wip label Mar 28, 2017
@lgalis
Copy link
Contributor Author

lgalis commented Mar 28, 2017

@miq-bot add_label bug, automation/ansible_tower

@lgalis lgalis mentioned this pull request Mar 28, 2017
Merged
@miq-bot
Copy link
Member

miq-bot commented Mar 28, 2017

@lgalis Cannot apply the following label because they are not recognized: automation/ansible_tower

@miq-bot miq-bot added the bug label Mar 28, 2017
@lgalis lgalis force-pushed the spec_for_url_sort_in_automation_provider_list branch from 1359992 to 89564bd Compare March 28, 2017 21:37
@miq-bot
Copy link
Member

miq-bot commented Mar 28, 2017

Checked commit lgalis@89564bd with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks good. 👍

@lgalis lgalis closed this Apr 12, 2017
@lgalis lgalis reopened this Apr 12, 2017
@lgalis lgalis changed the title [WIP]Spec for url sorting in the automation providers list Spec for url sorting in the automation providers list Apr 12, 2017
@miq-bot miq-bot removed the wip label Apr 12, 2017
@lgalis
Copy link
Contributor Author

lgalis commented Apr 12, 2017

@dclarizio - these are the specs for the changes made in the core PR mentioned above.

@lgalis
Copy link
Contributor Author

lgalis commented Apr 12, 2017

@miq-bot assign @dclarizio

@miq-bot
Copy link
Member

miq-bot commented Apr 13, 2017

@lgalis Cannot apply the following label because they are not recognized: fine/yes euwe/no

@lgalis
Copy link
Contributor Author

lgalis commented Apr 13, 2017

it can be backported - added the labels and the BZ

@lgalis
Copy link
Contributor Author

lgalis commented Apr 13, 2017

@miq-bot add_label fine/yes, euwe/no

@dclarizio dclarizio merged commit db1f852 into ManageIQ:master Apr 13, 2017
@dclarizio dclarizio added this to the Sprint 59 Ending Apr 24, 2017 milestone Apr 13, 2017
simaishi pushed a commit that referenced this pull request Apr 13, 2017
@simaishi
Merge pull request #828 from lgalis/spec_for_url_sort_in_automation_p…
b8c73e1 
…rovider_list

Spec for url sorting in the automation providers list
(cherry picked from commit db1f852)
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit b8c73e11edd41f9becd11274bf5020ce06cc04b0
Author: Dan Clarizio <[email protected]>
Date:   Thu Apr 13 06:40:42 2017 -0700

    Merge pull request #828 from lgalis/spec_for_url_sort_in_automation_provider_list
    
    Spec for url sorting in the automation providers list
    (cherry picked from commit db1f852a7a7d6f5fc27c3558fff865389b846af0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dclarizio dclarizio

Labels
automation/ansible tower bug fine/backported test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lgalis @miq-bot @simaishi @dclarizio