Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI for Embedded Ansible Provider refresh #934

Merged

Conversation

mzazrivec
Copy link
Contributor

@mzazrivec mzazrivec commented Apr 6, 2017

Embedded Ansible refresh (non-targeted) has been added into toolbars for
Ansible Credentials and Repositories.

Backend PR: ManageIQ/manageiq#14664

ansible-refresh-01
ansible-refresh-02

https://bugzilla.redhat.com/show_bug.cgi?id=1436982

@h-kataria
Copy link
Contributor

@mzazrivec are we adding Refresh button only on summary screen, i think it should be added on list view screens as well.

@mzazrivec
Copy link
Contributor Author

@h-kataria Yes, I added the refresh buttons to the list screens (credentials, playbooks, repositories). Not to the summary screens.

@mzazrivec mzazrivec force-pushed the refresh_for_embedded_ansible branch from 57edddf to 700f6c6 Compare April 10, 2017 08:29
@mzazrivec mzazrivec force-pushed the refresh_for_embedded_ansible branch from 700f6c6 to ee43d9e Compare April 10, 2017 18:10
@miq-bot
Copy link
Member

miq-bot commented Apr 10, 2017

Checked commit mzazrivec@ee43d9e with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
6 files checked, 7 offenses detected

app/helpers/application_helper/toolbar/ansible_credentials_center.rb

app/helpers/application_helper/toolbar/ansible_repositories_center.rb

@martinpovolny martinpovolny merged commit 548fed5 into ManageIQ:master Apr 10, 2017
@martinpovolny martinpovolny added this to the Sprint 58 Ending Apr 10, 2017 milestone Apr 10, 2017
@martinpovolny martinpovolny self-assigned this Apr 10, 2017
simaishi pushed a commit that referenced this pull request Apr 11, 2017
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit 26801bea969f889e4ed22b17b20fadbf2b22794f
Author: Martin Povolny <[email protected]>
Date:   Mon Apr 10 20:29:45 2017 +0200

    Merge pull request #934 from mzazrivec/refresh_for_embedded_ansible
    
    UI for Embedded Ansible Provider refresh
    (cherry picked from commit 548fed57e486eeef6eb576a67005714e138224e9)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1441253

@mzazrivec mzazrivec deleted the refresh_for_embedded_ansible branch September 11, 2017 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants