Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display missing HostEsx nodes on infra topology screens #994

Merged
merged 1 commit into from
Apr 12, 2017
Merged

Display missing HostEsx nodes on infra topology screens #994

merged 1 commit into from
Apr 12, 2017

Conversation

skateman
Copy link
Member

@skateman skateman commented Apr 11, 2017 •
edited
Loading

@miq-bot
Copy link
Member

miq-bot commented Apr 11, 2017

Checked commit skateman@8af91ec with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks good. 🍰

@skateman skateman changed the title Display missing HostEsx nodes on infra topology screens [WIP] Display missing HostEsx nodes on infra topology screens Apr 11, 2017
@miq-bot miq-bot added the wip label Apr 11, 2017
@skateman skateman changed the title [WIP] Display missing HostEsx nodes on infra topology screens Display missing HostEsx nodes on infra topology screens Apr 11, 2017
@miq-bot miq-bot removed the wip label Apr 11, 2017
@dclarizio
Copy link

@skateman can you add before/after screen shots?

@dclarizio dclarizio self-assigned this Apr 11, 2017
@skateman
Copy link
Member Author

@dclarizio sure, updated!

@dclarizio dclarizio requested a review from himdel April 11, 2017 16:45
@himdel
Copy link
Contributor

himdel commented Apr 12, 2017 •
edited
Loading

LGTM I guess.. I mean, certainly won't hurt doing this for Host, just wondering if we shouldn't call base_class always.

EDIT: .. except base_class doesn't always return what we want so.. next step maybe :)

@himdel himdel added this to the Sprint 59 Ending Apr 24, 2017 milestone Apr 12, 2017
@himdel himdel assigned himdel and unassigned dclarizio Apr 12, 2017
@himdel himdel merged commit 0556af1 into ManageIQ:master Apr 12, 2017
@skateman skateman deleted the vmware-topology-fix branch April 12, 2017 12:10
simaishi pushed a commit that referenced this pull request Apr 13, 2017
@himdel @simaishi
Merge pull request #994 from skateman/vmware-topology-fix
28a925a 
Display missing HostEsx nodes on infra topology screens
(cherry picked from commit 0556af1)

https://bugzilla.redhat.com/show_bug.cgi?id=1441657
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit 28a925a111fb50b3989734e945a645918d05e418
Author: Martin Hradil <[email protected]>
Date:   Wed Apr 12 12:10:34 2017 +0000

    Merge pull request #994 from skateman/vmware-topology-fix
    
    Display missing HostEsx nodes on infra topology screens
    (cherry picked from commit 0556af1f13eefb5380dd46df0db3a6bbaf3ad2d4)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1441657

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himdel himdel Awaiting requested review from himdel

Assignees

@himdel himdel

Labels
bug compute/infrastructure fine/backported topology
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@skateman @miq-bot @dclarizio @himdel @simaishi