Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform VM dialogs related to v2v are still present #21874

Open
Fryguy opened this issue May 23, 2022 Discussed in #21870 · 5 comments
Open

Transform VM dialogs related to v2v are still present #21874

Fryguy opened this issue May 23, 2022 Discussed in #21870 · 5 comments

Comments

@Fryguy
Copy link
Member

Fryguy commented May 23, 2022

Discussed in #21870

This seems to have been missed in the deletion of v2v.

$ ag-miq -i "Transform Vm"
/Users/jfrey/dev/manageiq-ui-service/tests/mock/rbac/allPermissions.json:1061:        "description": "Transform VM"
/Users/jfrey/dev/manageiq-ui-classic/app/controllers/mixins/actions/vm_actions/transform.rb:6:          dialog = Dialog.find_by(:label => 'Transform VM')
/Users/jfrey/dev/manageiq-ui-classic/app/controllers/mixins/actions/vm_actions/transform.rb:8:          @right_cell_text = _("Transform VM %{name} to RHV") % {:name => vm.name}
/Users/jfrey/dev/manageiq-ui-classic/app/controllers/mixins/actions/provider_actions/mass_transform.rb:6:          dialog = Dialog.find_by!(:label => 'Transform VM')
/Users/jfrey/dev/manageiq-ui-classic/app/controllers/mixins/actions/provider_actions/mass_transform.rb:7:          @right_cell_text = _("Transform VMs to RHV")
/Users/jfrey/dev/manageiq-ui-classic/app/controllers/vm_common.rb:1103:    %w[vm_transform vm_transform_mass].include?(params[:pressed])
/Users/jfrey/dev/manageiq-ui-classic/app/helpers/application_helper/button/transform_vm_button.rb:10:    @error_message = _('Can only transform VMs in down state') unless vm_down?
/Users/jfrey/dev/manageiq-ui-classic/app/helpers/application_helper/button/transform_vm_button.rb:11:    @error_message = _('Cannot transform VMs with snapshots') if vm_has_snapshots?
/Users/jfrey/dev/manageiq-ui-classic/spec/controllers/vm_infra_controller_spec.rb:448:  context 'transform VM dialog' do
/Users/jfrey/dev/manageiq-ui-classic/spec/controllers/vm_infra_controller_spec.rb:449:    let(:dialog)           { FactoryBot.create(:dialog, :label => 'Transform VM', :buttons => 'submit') }
/Users/jfrey/dev/manageiq/db/fixtures/miq_product_features.yml:5846:        :description: Transform VM
/Users/jfrey/dev/manageiq-providers-ovirt/CHANGELOG.md:128:- Set default tag category in 'Transform VM' dialog [(#135)](https://github.com/ManageIQ/manageiq-providers-ovirt/pull/135)
@miq-bot
Copy link
Member

miq-bot commented Feb 27, 2023

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

@miq-bot miq-bot added the stale label Feb 27, 2023
@Fryguy
Copy link
Member Author

Fryguy commented Mar 30, 2023

@MelsHyrule Can you verify if this is still a thing? If so, let's see if we can get this all deleted, as it might help with some of the angular stuff.

@Fryguy Fryguy removed the stale label Mar 30, 2023
@Fryguy Fryguy assigned MelsHyrule and unassigned jrafanie Mar 30, 2023
@miq-bot miq-bot added the stale label Jul 3, 2023
@miq-bot
Copy link
Member

miq-bot commented Jul 3, 2023

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

@Fryguy Fryguy removed the stale label Jul 3, 2023
@Fryguy Fryguy self-assigned this Jul 19, 2023
@Fryguy
Copy link
Member Author

Fryguy commented Jul 19, 2023

This may only appear on upgrades; not sure.

@miq-bot miq-bot added the stale label Oct 23, 2023
@miq-bot
Copy link
Member

miq-bot commented Oct 23, 2023

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

@Fryguy Fryguy removed the stale label Nov 1, 2023
@Fryguy Fryguy removed their assignment Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants