-
Notifications
You must be signed in to change notification settings - Fork 242
/
.rubocop.yml
400 lines (278 loc) · 6.4 KB
/
.rubocop.yml
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
require:
- rubocop-rails
- rubocop-performance
- rubocop-factory_bot
- rubocop-rspec
- rubocop-rspec_rails
- rubocop-capybara
AllCops:
Exclude:
- 'db/migrate/.*'
- 'db/schema.rb'
- 'lib/repo/test/.*'
- 'Vagrantfile'
NewCops: enable
SuggestExtensions: false
TargetRubyVersion: 2.7
Capybara/ClickLinkOrButtonStyle: # TODO: Enable and fix errors after reviewing system tests
Enabled: false
FactoryBot/AssociationStyle:
EnforcedStyle: explicit
FactoryBot/ConsistentParenthesesStyle:
EnforcedStyle: require_parentheses
Layout/EmptyLineAfterGuardClause:
Enabled: false
Layout/LineEndStringConcatenationIndentation:
Enabled: true
Layout/ExtraSpacing:
AllowBeforeTrailingComments: true
AllowForAlignment: false
Layout/FirstArrayElementIndentation:
EnforcedStyle: consistent
Layout/FirstHashElementIndentation:
EnforcedStyle: consistent
Layout/LineLength:
Max: 120
# Disable to allow method chaining aligned at the '.'
Layout/MultilineOperationIndentation:
Enabled: false
Layout/SpaceAroundOperators:
AllowForAlignment: false
EnforcedStyleForExponentOperator: space
Layout/SpaceBeforeBrackets:
Enabled: true
Lint/AmbiguousAssignment:
Enabled: true
Lint/AmbiguousOperatorPrecedence:
Enabled: false
Lint/AmbiguousRange:
Enabled: true
Lint/ConstantDefinitionInBlock:
Enabled: false
Lint/DeprecatedConstants:
Enabled: true
Lint/DuplicateBranch:
Enabled: true
IgnoreConstantBranches: false
IgnoreLiteralBranches: false
Lint/DuplicateRegexpCharacterClassElement:
Enabled: true
Lint/EmptyBlock:
Enabled: true
Lint/EmptyClass:
AllowComments: true
Enabled: true
Lint/EmptyInPattern:
Enabled: true
Lint/IncompatibleIoSelectWithFiberScheduler:
Enabled: false
Lint/LambdaWithoutLiteralBlock:
Enabled: true
Lint/MissingSuper:
Exclude:
- 'app/lib/*_repository.rb'
Lint/NoReturnInBeginEndBlocks:
Enabled: true
Lint/NonLocalExitFromIterator:
Enabled: false
Lint/NumberedParameterAssignment:
Enabled: true
Lint/OrAssignmentToConstant:
Enabled: true
# Enable this when we upgrade to Ruby version 3.0+
Lint/RedundantDirGlobSort:
Enabled: false
Lint/RequireRelativeSelfPath:
Enabled: false
Lint/SymbolConversion:
Enabled: true
Lint/ToEnumArguments:
Enabled: true
Lint/TripleQuotes:
Enabled: true
Lint/UnexpectedBlockArity:
Enabled: true
Lint/UnmodifiedReduceAccumulator:
Enabled: true
Lint/UnusedMethodArgument:
AllowUnusedKeywordArguments: true
IgnoreNotImplementedMethods: true
# Disable all Metrics checks
Metrics:
Enabled: false
Naming/AccessorMethodName:
Enabled: false
Naming/MethodParameterName:
MinNameLength: 1
Naming/PredicateName:
Enabled: false
# Performance checks
Performance/CollectionLiteralInLoop:
MinSize: 3
Rails/ActionOrder:
Enabled: false
Rails/HasAndBelongsToMany:
Enabled: false
Rails/HasManyOrHasOneDependent:
Enabled: false
Rails/HelperInstanceVariable:
Enabled: false
Rails/I18nLazyLookup:
Enabled: false
Rails/I18nLocaleTexts:
Enabled: false
Rails/OrderById:
Enabled: false
Rails/PluckId:
Enabled: true
Rails/RequireDependency:
Enabled: true
Rails/SkipsModelValidations:
Enabled: false
Rails/UniqueValidationWithoutIndex:
Enabled: false
RSpec/AnyInstance:
Enabled: false
RSpec/ContextWording:
Enabled: false
RSpec/DescribeClass: # Disabled because some suites are note testing classes or modules
Enabled: false
RSpec/DescribedClass:
EnforcedStyle: explicit
RSpec/EmptyExampleGroup: # Does not recognize ActionPolicy tests (succeed/failed)
Enabled: false
RSpec/ExampleLength:
Enabled: false
RSpec/ExampleWording:
Enabled: false
RSpec/ExpectChange:
EnforcedStyle: block
RSpec/IndexedLet:
Enabled: false
RSpec/InstanceVariable: # TODO: enable this check and fix the errors
Enabled: false
RSpec/MatchArray:
Enabled: false
RSpec/MessageSpies:
EnforcedStyle: receive
RSpec/MetadataStyle:
EnforcedStyle: hash
RSpec/MultipleExpectations:
Enabled: false
RSpec/MultipleMemoizedHelpers:
Enabled: false
RSpec/NamedSubject:
Enabled: false
RSpec/NestedGroups:
Enabled: false
RSpec/PendingWithoutReason:
Enabled: false
RSpec/ScatteredLet:
Exclude:
- spec/policies/**/*.rb
RSpec/ScatteredSetup:
Exclude:
- spec/policies/**/*.rb
RSpec/StubbedMock:
Enabled: false
Security/IoMethods:
Enabled: true
Style/AndOr:
EnforcedStyle: always
Style/ArgumentsForwarding:
Enabled: true
Style/CaseLikeIf:
Enabled: false
Style/ClassVars:
Enabled: false
Style/CollectionCompact:
Enabled: true
Style/CollectionMethods:
PreferredMethods:
find:
detect: find
Style/ConditionalAssignment:
Enabled: false
Style/DocumentDynamicEvalDefinition:
Enabled: true
Style/Documentation:
Enabled: false
# Enable this when we upgrade to Ruby version 3.0+
Style/EndlessMethod:
EnforcedStyle: disallow
Enabled: false
Style/FrozenStringLiteralComment:
Enabled: false
Style/GuardClause:
Enabled: false
Style/HashConversion:
Enabled: true
# Enable this when we upgrade to Ruby version 3.0+
Style/HashExcept:
Enabled: false
Style/IfUnlessModifier:
Enabled: false
Style/IfWithBooleanLiteralBranches:
Enabled: true
Style/InPatternThen:
Enabled: true
Style/Lambda:
EnforcedStyle: literal
# Enable when we commit to supporting only Ruby 2.6+
Style/MapToHash:
Enabled: false
Style/MultilineInPatternThen:
Enabled: true
Style/NegatedIfElseCondition:
Enabled: false
Style/Next:
Enabled: false
Style/NilLambda:
Enabled: true
Style/NumberedParameters:
Enabled: false
Style/NumberedParametersLimit:
Enabled: true
Style/NumericPredicate:
Enabled: false
Style/OpenStructUse:
Enabled: false
Style/ParallelAssignment:
Enabled: false
Style/QuotedSymbols:
Enabled: true
Style/RedundantArgument:
Enabled: true
Style/RedundantSelf:
Enabled: false
Style/RedundantSelfAssignmentBranch:
Enabled: true
Style/ReturnNil:
Enabled: true
Style/SafeNavigationChainLength:
Enabled: false
Style/SelectByRegexp:
Enabled: true
Style/Send:
Enabled: true
# Enable when we commit to supporting only Ruby 2.6+
Style/SlicingWithRange:
Enabled: false
Style/SpecialGlobalVars:
Enabled: true
Style/StringChars:
Enabled: true
Style/StringConcatenation:
Mode: conservative
Style/StringLiterals:
EnforcedStyle: single_quotes
Style/StringMethods:
Enabled: true
Style/SwapValues:
Enabled: true
Style/SymbolArray:
Enabled: false
Style/TrailingUnderscoreVariable:
Enabled: false
Style/ZeroLengthPredicate:
Enabled: false