Marlin does not correctly initialise Integral and Derivative values from configuration

[triffid]

Marlin does not correctly load my integral and derivative values at startup.

I have:

define DEFAULT_Kp 40.0

define DEFAULT_Ki 0.55

define DEFAULT_Kd 35

but after a reset when I send M301 I get:

ok p:40.00 i:4.20 d:4.59 c:0.13

I can send values using M301 and it stores them correctly from that point, but I'd rather that it loads them properly in the first place!

I am not using EEPROM settings.

Incidentally, I suggest you also make those values default for makergear/arcol/j-head. I tried the autotune and it gave me a constant +/-10c swing. I hand-tuned instead, got the above and they give me +/-0.5c. Others are reporting that they work really well too

[ErikZalm]

I tested it and i see no difference between the setting and the config file.
#define DEFAULT_Kp 22.2
#define DEFAULT_Ki 1.08
#define DEFAULT_Kd 114

M301
SENDING:M301
ok p:22.20 i:1.08 d:114.00 c:0.13

[jothan]

When I enabled the LCD code, I got a similar effect. Enabling EEPROM_SETTINGS, setting the PID values with M301 and saving to the EEPROM with M500 allowed me to have correct and stable PID values again.

It would seem that there is some duplication of responsibility between the LCD and EEPROM code.

[MrRocketman]

I'm running into the same issue. Using the LCD to change the PID values and then save to EEPROM does not seem to be having an effect.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.