Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Allow input shaping tuning during print #26653

Closed
vovodroid opened this issue Jan 9, 2024 · 10 comments · Fixed by #27248
Closed

[FR] Allow input shaping tuning during print #26653

vovodroid opened this issue Jan 9, 2024 · 10 comments · Fixed by #27248
Labels
T: Feature Request Features requested by users.

Comments

@vovodroid
Copy link
Contributor

Is your feature request related to a problem? Please describe.

No response

Are you looking for hardware support?

No response

Describe the feature you want

Currently input shaping could be tuned only when printer is in idle:

    // M593 - Acceleration items
    #if ENABLED(SHAPING_MENU)
      if (!is_busy) SUBMENU(MSG_INPUT_SHAPING, menu_advanced_input_shaping);
    #endif

Is is possible to allow frequency adjusting while printing?

Additional context

No response

@vovodroid vovodroid added the T: Feature Request Features requested by users. label Jan 9, 2024
@EvilGremlin
Copy link
Contributor

EvilGremlin commented Jan 9, 2024

Just remove condition, but what's the point? Adjusting on real print is absolutely useless, you won't be able to see any difference. Just print calibration tower.

@vovodroid
Copy link
Contributor Author

vovodroid commented Jan 9, 2024

Just remove condition

Will it work? I mean will it affect planner immediately?

what's the point?

I confused with X and Y settings before 10 hours print))). Noted it after several hours.

@EvilGremlin
Copy link
Contributor

I don't think that very specific user error warrants any code changes... and you could've fix it with gcode.

@vovodroid
Copy link
Contributor Author

you could've fix it with gcode.

In the middle of the print?

@EvilGremlin
Copy link
Contributor

yep

@vovodroid
Copy link
Contributor Author

How? Could gcode commands issued via COM port while printing?

@EvilGremlin
Copy link
Contributor

EvilGremlin commented Jan 9, 2024

of course

@vovodroid
Copy link
Contributor Author

vovodroid commented Jul 5, 2024

Just remove condition, but what's the point? Adjusting on real print is absolutely useless, you won't be able to see any difference. Just print calibration tower.

@EvilGremlin I found it extremely useful while tuning IS. I run gcode loop moving extruder/bed with frequency oscillating back and force within given range, and adjust IS until I get the most smooth result.

@vovodroid
Copy link
Contributor Author

PR #27248 is created

Copy link

github-actions bot commented Sep 4, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T: Feature Request Features requested by users.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants