Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lineage response includes type twice in DatasetData #1527

Closed
collado-mike opened this issue Jul 15, 2021 · 1 comment · Fixed by #2623
Closed

Lineage response includes type twice in DatasetData #1527

collado-mike opened this issue Jul 15, 2021 · 1 comment · Fixed by #2623
Labels
bug Something isn't working

Comments

@collado-mike
Copy link
Collaborator

The DatasetData implementation of NodeData has its own type field- either DB_TABLE or a STREAM. However, the NodeData interface is annotated to include @JsonTypeInfo using the type field. This results in the DatasetData rendering with two type fields.

Example response below

{
  "graph": [
    {
      "id": "dataset:food_delivery:public.categories",
      "type": "DATASET",
      "data": {
        "type": "DATASET",
        "id": {
          "namespace": "food_delivery",
          "name": "public.categories"
        },
        "type": "DB_TABLE",
        "name": "public.categories",
        "physicalName": "public.categories",
        "createdAt": "2021-03-09T02:33:18.468719Z",
        "updatedAt": "2021-07-15T05:06:46.064956Z",
        "namespace": "food_delivery",
        "sourceName": "analytics_db",
        "fields": [
          {
            "name": "id",
            "type": "INTEGER",
            "tags": [],
            "description": "The unique ID of the category."
          },
          {
            "name": "name",
            "type": "VARCHAR",
            "tags": [],
            "description": "The name of the category."
          },
          {
            "name": "menu_id",
            "type": "INTEGER",
            "tags": [],
            "description": "The ID of the menu related to the category."
          },
          {
            "name": "description",
            "type": "TEXT",
            "tags": [],
            "description": "The description of the category."
          }
        ],
        "tags": [],
        "lastModifiedAt": "2021-07-15T05:02:15.064956Z",
        "description": null
      },
      "inEdges": [
        {
          "origin": "job:food_delivery:example.etl_categories",
          "destination": "dataset:food_delivery:public.categories"
        }
      ],
      "outEdges": [
        {
          "origin": "dataset:food_delivery:public.categories",
          "destination": "job:food_delivery:example.etl_orders_7_days"
        }
      ]
    }
]
@julienledem
Copy link
Member

also covers: #1471

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants