Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web UI - quality display #2839

Closed
namyyys opened this issue Jun 21, 2024 · 4 comments · Fixed by #2844
Closed

Web UI - quality display #2839

namyyys opened this issue Jun 21, 2024 · 4 comments · Fixed by #2844

Comments

@namyyys
Copy link
Contributor

namyyys commented Jun 21, 2024

Quality is deemed as unhealthy but the text is displayed in green instead of red.

Capture d’écran 2024-06-21 à 16 45 26

Copy link

boring-cyborg bot commented Jun 21, 2024

Thanks for opening your first issue in the Marquez project! Please be sure to follow the issue template!

@phixMe
Copy link
Member

phixMe commented Jun 25, 2024

Can you dig into the root cause of this a little for us and evaluate our conditional logic along with the OpenLineage events that you have defined?

The logic we have for this lies here:
https://github.com/MarquezProject/marquez/blob/main/web/src/routes/datasets/Datasets.tsx#L219-L230

@namyyys
Copy link
Contributor Author

namyyys commented Jun 27, 2024

I tried to dig into the root cause a little bit. From my analysis i think it's coming from this function
I encounter this issue with a dataset, for example, which has 34 assertions (32 passing and 2 failing). In the logic i see from the above function, the color of the quality is only tested on a subset of all the assertions (the last 14 i believe). We think that the 2 failing cases are not included in this subset and thus the coloring is wrong.

@phixMe
Copy link
Member

phixMe commented Jun 27, 2024

Yes, thanks, I just submitted a PR to rectify this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants