verifyRegistrationResponse throwing extraneous error for invalid check? (seems to be anyway) #679
jimmont
started this conversation in
Troubleshooting
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
a2b2315#diff-926309e75fe5697e8d26ca811125ff990f6aed442d3e2ecbd8fa790439f52a9fR53
is this correct?
I'm not understanding how this ensures the
id
is anything in particular--especially base64url-encoded. (I must not be understanding something.)SimpleWebAuthn/packages/server/src/registration/verifyRegistrationResponse.ts
Line 75 in a169def
My understanding is that
credential.id
is a string whilecredential.rawId
is a buffer so this comparison should always throw--and that doesn't seem to be the desired effect. If this is correct (is it?) it seems this section of checks might benefit from review and either removal or improvement.Beta Was this translation helpful? Give feedback.
All reactions