Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let the user choose which reveal animation to run #100

Open
Mauker1 opened this issue May 15, 2017 · 0 comments
Open

Let the user choose which reveal animation to run #100

Mauker1 opened this issue May 15, 2017 · 0 comments
Assignees
Milestone

Comments

@Mauker1
Copy link
Owner

Mauker1 commented May 15, 2017

As of version 1.2.2, if we choose to animate the search view when we're opening it, the animation type is decided based on the API level. If the device is running a pre-lollipop android, it'll use fade-in and fade-out, for api 21+ it'll use circular reveal.

It might be interesting to let the user choose what kind of animation should be used, if any.

Possible problems:

  • CircularReveal won't work on pre-lollipop. Unless we get the animation from a third party lib, but it'll just make MSV bigger.
  • Should we add custom animations? If so, we should also consider a "custom" animation type.
@Mauker1 Mauker1 added this to the 2.0.0 milestone May 15, 2017
@Mauker1 Mauker1 modified the milestones: 2.0.0, 2.1.0 Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants