Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement suggestion : listview instead of layout_height wrap_content, use XXXdp #28

Open
x4080 opened this issue Jun 27, 2016 · 5 comments

Comments

@x4080
Copy link

x4080 commented Jun 27, 2016

This will allow scroll when keyboard is shown, especially in the landscape mode

And speaking of landscape, maybe if 2 layout available for XXXdp sizes for portrait and landscape it will be better

Thanks

@Mauker1
Copy link
Owner

Mauker1 commented Jun 27, 2016

Could you explain your suggestion a little better? Maybe provide an example.

@x4080
Copy link
Author

x4080 commented Jun 28, 2016

I mean using static height so that the list is above the keyboard and can be scrolled

@Mauker1
Copy link
Owner

Mauker1 commented Jun 28, 2016

I think that will be hard to get right, given the number of screen sizes, soft keyboard sizes (and even 3rd party keyboards). And if the user dismisses the keyboard, the list won't get any bigger.

@x4080
Copy link
Author

x4080 commented Jun 28, 2016

that's correct, i just use some value for portrait and smaller value for landscape, Google search also use static size btw

@Mauker1
Copy link
Owner

Mauker1 commented Feb 8, 2017

@AdamMc331 Any thoughts on this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants