Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TF-PSA-Crypto out of source build #9767

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

TF-PSA-Crypto out of source build #9767

wants to merge 1 commit into from

Conversation

Harry-Ramsey
Copy link
Contributor

@Harry-Ramsey Harry-Ramsey commented Nov 11, 2024 •
edited
Loading

Description

Closes #9755

PR checklist

Please remove the segment/s on either side of the | symbol as appropriate, and add any relevant link/s to the end of the line.
If the provided content is part of the present PR remove the # symbol.

  • changelog not required because: testing API changes.
  • development PR provided.
  • framework PR provided #77
  • 3.6 PR not required because: for repo split.
  • 2.28 PR not required because: for repo split.
  • tests not required.

Notes for the submitter

Please refer to the contributing guidelines, especially the
checklist for PR contributors.

Help make review efficient:

  • Multiple simple commits
    • please structure your PR into a series of small commits, each of which does one thing
  • Avoid force-push
    • please do not force-push to update your PR - just add new commit(s)
  • See our Guidelines for Contributors for more details about the review process.

@Harry-Ramsey Harry-Ramsey changed the title Tf psa crypto out of source development tf-psa-crypto out of source development Nov 11, 2024
@Harry-Ramsey Harry-Ramsey changed the title tf-psa-crypto out of source development tf-psa-crypto out of source build Nov 11, 2024
@Harry-Ramsey
Copy link
Contributor Author

Harry-Ramsey commented Nov 11, 2024 •
edited
Loading

This should pass all tests except test_tf_psa_crypto_cmake_as_package. I believe going forward all tf-psa-crypto components should include tf_psa_crypto in the name.

I have another branch where I attempted to use --list-all-components however the race conditions from forking due to bash substitutions were too chaotic to manage with some tests failing and other succeeding at will.

@Harry-Ramsey Harry-Ramsey self-assigned this Nov 11, 2024
@Harry-Ramsey Harry-Ramsey force-pushed the tf-psa-crypto-out-of-source-development branch from ba66691 to 9a0200c Compare November 12, 2024 12:26
@Harry-Ramsey Harry-Ramsey added enhancement needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review priority-high High priority - will be reviewed soon size-s Estimated task size: small (~2d) labels Nov 12, 2024
@Harry-Ramsey Harry-Ramsey mentioned this pull request Nov 14, 2024
Open
5 tasks
@Harry-Ramsey Harry-Ramsey force-pushed the tf-psa-crypto-out-of-source-development branch from 9a0200c to de49f62 Compare November 18, 2024 10:47
@Harry-Ramsey Harry-Ramsey mentioned this pull request Nov 18, 2024
Open
@Harry-Ramsey Harry-Ramsey changed the title tf-psa-crypto out of source build TF-PSA-Crypto out of source build Nov 18, 2024
@Harry-Ramsey Harry-Ramsey added the needs-preceding-pr Requires another PR to be merged first label Nov 20, 2024
@Harry-Ramsey
Remove duplicate out of source code
22a36f8 
This commit removes duplicate code to build TF-PSA-Crypto out of source
which has now been moved to mbedtls-framework.

Signed-off-by: Harry Ramsey <[email protected]>
@Harry-Ramsey Harry-Ramsey force-pushed the tf-psa-crypto-out-of-source-development branch from de49f62 to 22a36f8 Compare November 20, 2024 15:07
@Harry-Ramsey Harry-Ramsey removed the needs-preceding-pr Requires another PR to be merged first label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Harry-Ramsey Harry-Ramsey

Labels
enhancement needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review priority-high High priority - will be reviewed soon size-s Estimated task size: small (~2d)
Projects
Roadmap pull requests (new board)
Status: In Development
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tf-psa-crypto all.sh: make the core manage the build directory
1 participant
@Harry-Ramsey