-
Notifications
You must be signed in to change notification settings - Fork 966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #70 - Replacing current static resource keys with new dynamic keys #106
Conversation
…ig refactor & I think it requires approval for the idea before proceeding.
Conflicts: src/Humanizer.Tests/DateHumanizeTests.cs
I like where you're going with this and I think this is cleaner than the current implementation. |
Could you take out all the Dynamic folders and namespaces? I don't think we need to let the implementation details show up in the folder structure or namespace. Perhaps as discussed in email, close this one and send a new PR with latest changes. |
…ages & added a missing test case.
TeamCity is down!! I'll check failing build as soon as it's build server is back online. |
|
||
namespace Humanizer.Tests | ||
{ | ||
public class DateHumanizeOneTimeUnitTests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need these tests? These are already verified in DateHumanizeTests.
Those were introduced in previous time to verify the new way of resource key generation. They don't have much value at the moment so you can decide either to leave or to delete them. |
I made a few changes and also refactored IFormatter, DefaultFormatter and TimeSpan.Humanize. Please check it out and let me know what you think. |
I like the _TimeSpanFormatter_ refactoring, it's just the very logical next step 👍 I think this enough refactoring for Date.Humanize() at the moment we better move to precision issue which again will require thinking about Date.Humanize but in a new context. I'm thinking if we can introduce a different strategies that would be better. |
I was a bit unsure about I don't think there's a need for strategy for implementing precision. It should be relatively easy; but I think the |
/// <param name="format">string format</param> | ||
/// <param name="args">arguments</param> | ||
/// <returns></returns> | ||
public static string FormatWith(this string format, params object[] args) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is nice. I don't know how this skipped under my radar. Please add unit tests for it and also add it to the readme with an entry on the table of content (in a new PR).
In this pull request, I have merge recent changes from original repository and completed refactoring we started last time.