Hungarian localization and tests #179
Conversation
| } | ||
|
|
||
| [Theory] | ||
| [InlineData(0, 3, "nincs idő")] |
There was a problem hiding this comment.
Please remove this test. This has been covered by the English test and the tests you wrote above.
|
Thanks for the great contribution. Please fix the comments and also go through this checklist as there are a few things you've missed. Please leave me a comment here when you're done so I can check it out and merge. |
|
I hopefully fixed all the problems with the tests. I went through the checklist and I also updated the release notes. I do not have resharper, so I am not sure if there are any warnings or not. Please, review the change and let me know, if anything else is needed. |
| } | ||
|
|
||
| [Theory] | ||
| [InlineData(135, "2 perc")] |
|
Thanks for the fixes. I left a few comments. No worries about R#. |
fixes the null exception on date humanize
|
I rebased the git repo (never did this before) and removed the tests. Fingers crossed :) |
|
I rebased your work, made a few changes and pushed up. Thanks. |
|
This is now published to NuGet as v1.21.1. Thanks. |
|
Any change we can get a numbers to words for Hungarian? I have a need for it in writing out check amounts in multiple languages, one of which is Hungarian. |
|
@LBobirca Can you please describe the problem with the numbers to words in Hungarian? I did the original work for the Hungarian localization and I would help you fix this issue if I have a good understanding of what the problem is. Thanks, Krisztian |
Created the resource file and date, timespan for Hungarian locale. Please, review it and let me know if anything needs to be changed