-
Notifications
You must be signed in to change notification settings - Fork 966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Slovenian localisation #244
Conversation
|
||
[Theory] | ||
[InlineData(-10, "pred 10 leti")] | ||
[InlineData(-5, "pred 5 leti")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, for years 5 is the same as 3 and 4?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slovenian is quite a strange language. For years ago 3,4,5,... are the same. For years from now 3 and 4 are the same and everything from 5 on is the same.
This difference for numbers 3 and 4 occurs only when counting. We don't have actual trial or quadral grammatical numbers (we do have dual tho). I implemented this by using a different postfix for dual and one combined one for 3 and 4. Which is why some test seems duplicate since in some cases 3 and 4 are the same a 5. Those tests check if the resource files does indeed have the (duplicate) value for number 3 and 4.
Well testing for 10 could probably be omitted, since it's always the same as for 5.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hehe, cool. Thanks for explaining. Just wanted to make sure :)
Thanks. This is merged now. |
This is now available on NuGet as v1.25.4. |
No description provided.