Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Norwegian (nb-NO) localization and tests #26

Merged
merged 1 commit into from
Nov 11, 2013

Conversation

erlendr
Copy link

@erlendr erlendr commented Nov 11, 2013

This adds Norwegian bokmål localization and tests (tests based on fi-FI)

@MehdiK
Copy link
Member

MehdiK commented Nov 11, 2013

Thanks for the contribution. Going through it now.

Just a quick question: does Norwegian have complex language rules around dealing with numbers, like Romanian, that could impact the localisation or it's straightforward one-to-one association with the English resources?

@MehdiK MehdiK merged commit d08e79e into Humanizr:master Nov 11, 2013
@MehdiK
Copy link
Member

MehdiK commented Nov 11, 2013

Looks good. Merged. Thanks.

@erlendr
Copy link
Author

erlendr commented Nov 11, 2013

Thanks :) To answer your question about language rules: Norwegian is pretty straight forward when it comes to numbers, so the English resources match up well.

@MehdiK
Copy link
Member

MehdiK commented Nov 11, 2013

Cool. Thanks for the contribution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants