provide untyped comparison for ByteSize #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| [InlineData(13, 23, -1)] | ||
| [InlineData(23, 23, 0)] | ||
| [InlineData(45, 23, 1)] | ||
| public void CompareUntyped(double value, double valueToCompareWith, int expectedResult) |
There was a problem hiding this comment.
Thanks for the unit tests. I'd also like to see tests for sorting here; e.g. 1GB, 3KB and 5MB should sort to 3KB, 5MB and 1GB.
|
Thanks. I didn't realize it was already implementing |
|
Added sorting tests. I'm glad to help when I can :) |
MehdiK
added a commit
that referenced
this pull request
Jun 12, 2014
provide untyped comparison for ByteSize
|
This is now released to NuGet as v1.27.0. Thanks for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #292