Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support negative timespans #438

Merged
merged 1 commit into from
Jul 2, 2015
Merged

support negative timespans #438

merged 1 commit into from
Jul 2, 2015

Conversation

jeremysimmons
Copy link
Contributor

fixes issue reported in #434

MehdiK added a commit that referenced this pull request Jul 2, 2015
@MehdiK
Merge pull request #438 from jeremysimmons/master
652720e 
support negative timespans
@MehdiK MehdiK merged commit 652720e into Humanizr:master Jul 2, 2015
@MehdiK MehdiK mentioned this pull request Jul 2, 2015
Closed
@MehdiK
Copy link
Member

MehdiK commented Jul 2, 2015

I don't think this fixes #434. That looks like a logic error. This fixes #436 though. Thanks for the fix.

@MehdiK
Copy link
Member

MehdiK commented Jul 2, 2015

Thanks for the contribution. This is now released to NuGet as v1.37.0.

@jeremysimmons
Copy link
Contributor Author

sorry for the wrong tag. thanks for the pull.

On Jul 2, 2015, at 12:02 PM, Mehdi Khalili [email protected] wrote:

I don't think this fixes #434. That looks like a logic error. This fixes #436 though. Thanks for the fix.

—
Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeremysimmons @MehdiK