Changed OrdinalizeExtensions to better accommodate localisations. #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added pt-br Ordinalize localisation.
Minor code formatting fixes and cleanup.
|
Since @thunsaker said Spanish rules are exactly the same, I added Spanish localisation too. Hope I didn't get something wrong. Would be great if someone could validate all these changes. I'll check tomorrow if there are any problems. |
|
Spanish additions look good, (one inline comment). Thanks for doing it. |
| [InlineData("102", "102º")] | ||
| [InlineData("103", "103º")] | ||
| [InlineData("1001", "1001º")] | ||
| public void OrdinalizeString(string number, string ordinalized) |
There was a problem hiding this comment.
Rename this to Ordinalize please
Never mind. I see the reason now.
|
Thanks @akamud. Great work. Please leave us a comment when the feedback is applied. |
…l Gender for Ordinalizer. Fixed some typos and code clean-up.
|
Please check if everything is correct now. I'll be back home tonight if there's still something wrong. |
|
Thank you for making them @MehdiK, I wouldn't be able to fix them until later tonight. |
|
Thanks for the contribution. This is now available on NuGet as v1.23.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added pt-br Ordinalize localisation.