Fix: Add build step for generated project #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also took the liberty of bumping the |
Resolves Melkeydev#195 This pr adds a build step in CI that tries to build the generated project. This checks for typos of just general mistakes in syntax in the generated code.
MitchellBerend
force-pushed
the
fix/ci-build-project
branch
from
b0d72fc
to
0c11950
Compare
briancbarrow
approved these changes
Mar 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.
Problem/Feature
Resolves #195
In #174 I had some syntax errors in the templates that ended up in the final generated code. Since all the CI tests passed I assumed all the projects were at least compiling. Turns out this assumption was wrong.
Description of Changes:
This pr adds the advanced flag to the linting matrix step in CI that checks the generated project. This checks for typos of just general mistakes in syntax in the generated code of the advanced features as well.
This pr also fixes all the linting errors that popped up by adding the advanced features to the checks.
Checklist
- [ ] I have updated the documentation (if applicable)