Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added db schema to postgres template #245

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

ashupednekar
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

Problem/Feature

The current postgres service didn't accept schema and used public by default. Added support for specifying schema through envs

Description of Changes:

  • added DB_SCHEMA env to postgres template
  • passed search_path in dsn

Checklist

  • [*] I have self-reviewed the changes being requested
  • I have updated the documentation (if applicable)

@ashupednekar
Copy link
Contributor Author

@Melkeydev pls take a look

Copy link
Contributor

@H0llyW00dzZ H0llyW00dzZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need fix here

cmd/template/dbdriver/files/service/postgres.tmpl Outdated Show resolved Hide resolved
Copy link
Collaborator

@Ujstor Ujstor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ujstor Ujstor merged commit 1750ccf into Melkeydev:main Jun 12, 2024
127 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants