Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: added special treatment of advanced flag in tip string #254

Merged
merged 1 commit into from
Jun 16, 2024

Conversation

LrsK
Copy link
Contributor

@LrsK LrsK commented Jun 10, 2024

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

Problem/Feature

The line that prints after the program exits. giving a quick command line version of the same options, had a bug in it that would show the --advanced true/false no matter what. This flag doesn't need a true or a false value to be passed in, only its inclusion is enough to go to advanced mode.

Description of Changes:

  • Added check for all bool-flags, and changed the generated command accordingly. This is only applicable to advanced-flag, but will work for all bool-flags in the future.

Checklist

  • I have self-reviewed the changes being requested
  • I have updated the documentation (if applicable)

Copy link
Collaborator

@Ujstor Ujstor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ujstor Ujstor merged commit fef23e3 into Melkeydev:main Jun 16, 2024
127 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants