Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed nondbMakeFile #273

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Removed nondbMakeFile #273

merged 2 commits into from
Jul 10, 2024

Conversation

brijesh-amin
Copy link
Contributor

@brijesh-amin brijesh-amin commented Jul 9, 2024

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

Problem/Feature

There are two make files with almost identical content. I have removed nondbMakeFile to provide more flexibility in the future and easier templating.

Description of Changes:

Checklist

Copy link
Collaborator

@Ujstor Ujstor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tailwind and Htmx flags are connected...if Tailwind is selected, Htmx templates will also be generated. In that case, we need to add '@templ generate' to the Makefile build.

Copy link
Collaborator

@Ujstor Ujstor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ujstor Ujstor merged commit 528ae1f into Melkeydev:main Jul 10, 2024
127 checks passed
@Ujstor Ujstor mentioned this pull request Jul 10, 2024
1 task
@Ujstor
Copy link
Collaborator

Ujstor commented Jul 10, 2024

@brijesh-amin My mistake, I merged it, but you added Submodule xs. If you won't you can open a PR and remove the linked folder

@brijesh-amin
Copy link
Contributor Author

@brijesh-amin My mistake, I merged it, but you added Submodule xs. If you won't you can open a PR and remove the linked folder

My bad I was testing and did not realize xs got added. Will remove it now.

@brijesh-amin brijesh-amin deleted the remove-nodbmakefile branch July 10, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants