chore: update lint tools versions + use ts 5 #55

ccharly · 2024-09-24T14:22:49Z

Updating eslint and other similar packages.

socket-security · 2024-09-25T08:22:53Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@es-joy/[email protected]	None	`0`	113 kB	brettz9
npm/@eslint-community/[email protected]	None	`0`	446 kB	eslint-community-bot
npm/@eslint/[email protected]	filesystem, unsafe	`0`	659 kB	eslintbot
npm/@eslint/[email protected]	None	`0`	13.9 kB	eslintbot
npm/@humanwhocodes/[email protected]	None	`0`	58.4 kB	nzakas
npm/@humanwhocodes/[email protected]	None	`0`	23.3 kB	nzakas
npm/@metamask/[email protected]	None	`0`	9.35 kB	metamaskbot
npm/@metamask/[email protected]	None	`0`	95.4 kB	metamaskbot
npm/@metamask/[email protected]	None	`0`	19.1 kB	metamaskbot
npm/@metamask/[email protected]	None	`0`	120 kB	metamaskbot
npm/@pkgr/[email protected]	None	`0`	8.54 kB	jounqin
npm/@typescript-eslint/[email protected]	None	`0`	2.65 MB	bradzacher, jameshenry
npm/@typescript-eslint/[email protected]	None	`0`	18.7 kB	bradzacher, jameshenry
npm/@typescript-eslint/[email protected]	None	`0`	602 kB	bradzacher, jameshenry
npm/@typescript-eslint/[email protected]	None	`0`	121 kB	bradzacher, jameshenry
npm/@typescript-eslint/[email protected]	None	`0`	171 kB	jameshenry
npm/@typescript-eslint/[email protected]	None	`0`	587 kB	jameshenry
npm/@typescript-eslint/[email protected]	None	`0`	283 kB	bradzacher, jameshenry
npm/@typescript-eslint/[email protected]	None	`0`	19.5 kB	jameshenry
npm/@ungap/[email protected]	None	`0`	26.2 kB	webreflection
npm/[email protected]	None	`0`	13.6 kB	joshuakgoldberg
npm/[email protected]	unsafe	`0`	4.51 kB	sindresorhus
npm/[email protected]	None	`0`	366 kB	yavorskiys
npm/[email protected]	None	`0`	9.75 kB	sindresorhus
npm/[email protected]	filesystem	`0`	53.1 kB	ota-meshi
npm/[email protected]	None	`0`	409 kB	eslint-community-bot
npm/[email protected]	None	`0`	638 kB	jounqin
npm/[email protected]	filesystem	`0`	325 kB	simenb
npm/[email protected]	filesystem	`0`	1.38 MB	gajus
npm/[email protected]	filesystem	`0`	348 kB	weiran.zsd
npm/[email protected]	None	`0`	72.5 kB	eslint-community-bot
npm/[email protected]	None	`0`	146 kB	eslintbot
npm/[email protected]	None	`0`	32.3 kB	eslintbot
npm/[email protected]	environment, filesystem	`0`	3.04 MB	eslintbot
npm/[email protected]	None	`0`	73.6 kB	eslintbot
npm/[email protected]	None	`0`	1.04 MB	michaelficarra
npm/[email protected]	None	`0`	4.54 kB	sindresorhus
npm/[email protected]	filesystem	`0`	105 kB	hirokiosame
npm/[email protected]	None	`0`	5.57 kB	fisker
npm/[email protected]	None	`0`	25.1 kB	sindresorhus
npm/[email protected]	None	`0`	3.88 kB	sindresorhus
npm/[email protected]	None	`0`	4.08 kB	sindresorhus
npm/[email protected]	None	`0`	242 kB	jsdoc-type-pratt-parser
npm/[email protected]	None	`0`	5.55 kB	matzkoh
npm/[email protected]	None	`0`	15 kB	hirokiosame
npm/[email protected]	None	`0`	33.3 kB	keithamus
npm/[email protected]	None	`0`	5.46 kB	quietshu
npm/[email protected]	None	`0`	3.91 kB	sindresorhus
npm/[email protected]	environment	`0`	55.7 kB	jounqin
npm/[email protected]	None	`0`	828 kB	joshuakgoldberg
npm/[email protected]	None	`0`	32.4 MB	typescript-bot

View full report↗︎

….0.0)

ccharly · 2024-09-30T08:38:52Z

packages/keyring-eth-ledger-bridge/src/ledger-keyring.ts

    return this.bridge.destroy();
  }

-  async serialize() {
+  async serialize(): Promise<Partial<LedgerBridgeKeyringOptions>> {


I did this, but maybe we should have a dedicated type for the state here?

ccharly · 2024-09-30T08:43:00Z

packages/keyring-eth-trezor/src/trezor-connect-bridge.ts

@@ -35,29 +40,36 @@ export class TrezorConnectBridge implements TrezorBridge {
    this.trezorConnectInitiated = true;
  }

-  dispose() {
+  async dispose(): Promise<void> {


Was not async but since it's returning a Promise it makes sense to make it async

ccharly · 2024-09-30T08:45:15Z

packages/keyring-eth-trezor/src/trezor-keyring.ts

@@ -116,14 +125,14 @@ export class TrezorKeyring extends EventEmitter {
    return this.bridge.model;
  }

-  init() {
+  async init(): Promise<void> {


Was not async but since it's returning a Promise it makes sense to make it async.

Also, the KeyringController is already awaiting those calls: https://github.com/MetaMask/core/blob/main/packages/keyring-controller/src/KeyringController.ts#L2199-L2201

ccharly · 2024-09-30T08:46:31Z

packages/keyring-eth-trezor/src/trezor-keyring.ts

-  /**
-   * EIP-712 Sign Typed Data
-   */
+  // EIP-712 Sign Typed Data


Using a simple comment here, since most of those method are using this pattern

packages/keyring-snap-bridge/src/SnapKeyring.ts

ccharly

I did review (but cannot approve since I have some commits here). Left some comments with some open-questions + to explain some of the changes that were made by me.

gantunesr

Looking good, left a few comments

jest.config.packages.js

packages/keyring-api/src/rpc-handler.ts

packages/keyring-eth-ledger-bridge/src/ledger-hw-app.ts

packages/keyring-eth-ledger-bridge/src/ledger-keyring.ts

packages/keyring-eth-ledger-bridge/test/document.shim.ts

gantunesr

Minor nits!

packages/keyring-api/src/superstruct.test-d.ts

packages/keyring-api/src/superstruct.ts

packages/keyring-eth-ledger-bridge/test/document.shim.ts

packages/keyring-eth-simple/src/simple-keyring.test.ts

packages/keyring-eth-simple/src/simple-keyring.ts

packages/keyring-eth-simple/src/simple-keyring.test.ts

ccharly force-pushed the chore/update-lint-tools-versions branch from 371fbf7 to 2435299 Compare September 25, 2024 08:22

ccharly force-pushed the chore/update-lint-tools-versions branch from 2435299 to 32704ca Compare September 27, 2024 07:30

ccharly added 7 commits September 27, 2024 09:31

chore: update eslint (^8.55.0) + align @metamask/eslint-config-* (^13…

9e3dd15

….0.0)

chore: update rimraf (^5.0.10) + prettier-plugin-packagejson (^2.5.2)

a743d76

refactor(keyring-api): fix new eslint errors

4eae793

refactor(keyring-eth-hd): fix new eslint errors

0575f0e

refactor(keyring-eth-ledger-bridge): fix new eslint errors

64d25e1

refactor(keyring-eth-trezor): fix new eslint errors

4e66c6e

refactor(keyring-snap-bridge): fix new eslint errors

aae45b7

ccharly force-pushed the chore/update-lint-tools-versions branch from 32704ca to aae45b7 Compare September 27, 2024 07:31

danroc and others added 11 commits September 27, 2024 09:59

chore: fix more linting errors

1c35590

refactor(keyring-eth-trezor): fix new eslint errors

b31ba85

chore: fix more linting errors

bf8f086

chore: fix more linting errors

d6f7572

chore(deps): align versions of rimraf

59b1046

chore: update yarn.lock

e32dcb0

chore(deps): update eslint-plugin-jest

5a8cc28

chore: rename expectSync to noPending

10e55ef

chore(deps-dev): bump 'typescript' to 5.4.5

79a7804

chore: comment unused 'setup.ts' file

3aab831

chore: update expectSync -> noPending

8d8a883

danroc force-pushed the chore/update-lint-tools-versions branch from 7e43d4b to 4e2b067 Compare September 30, 2024 07:57

chore(eslint): disable false positive

6f9a4a8

danroc force-pushed the chore/update-lint-tools-versions branch from 4e2b067 to 6f9a4a8 Compare September 30, 2024 08:15

danroc marked this pull request as ready for review September 30, 2024 08:19

danroc requested a review from a team as a code owner September 30, 2024 08:19

ccharly changed the title ~~chore: update lint tools versions~~ chore: update lint tools versions + use ts 5 Sep 30, 2024

ccharly commented Sep 30, 2024

View reviewed changes

packages/keyring-snap-bridge/src/SnapKeyring.ts Outdated Show resolved Hide resolved

chore: switch #validateRedirectUrl back to a sync method

54eb2a9

danroc force-pushed the chore/update-lint-tools-versions branch from c5bda3a to 54eb2a9 Compare September 30, 2024 08:53

ccharly commented Sep 30, 2024

View reviewed changes

gantunesr reviewed Oct 1, 2024

View reviewed changes

ccharly added 2 commits October 1, 2024 09:49

refactor(keyring-eth-ledger-bridge): export AccountPage{,Entry}

006878f

refactor(keyring-eth-trezor): export AccountPage{,Entry}

f916f75

ccharly mentioned this pull request Oct 1, 2024

chore: update @metamask and peers depedencies #28

Closed

gantunesr reviewed Oct 1, 2024

View reviewed changes

ccharly added 2 commits October 1, 2024 15:46

chore(keyring-eth-ledger-bridge): add more comments

0ebf5a7

refactor(keyring-eth-simple): rename import './simple-keyring' to '.'

fff0e11

ccharly force-pushed the chore/update-lint-tools-versions branch from c1696c4 to fff0e11 Compare October 1, 2024 13:46

gantunesr approved these changes Oct 1, 2024

View reviewed changes

ccharly enabled auto-merge October 1, 2024 13:56

ccharly added this pull request to the merge queue Oct 1, 2024

Merged via the queue into main with commit cb10ee6 Oct 1, 2024
24 checks passed

ccharly deleted the chore/update-lint-tools-versions branch October 1, 2024 14:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: update lint tools versions + use ts 5 #55

chore: update lint tools versions + use ts 5 #55

ccharly commented Sep 24, 2024

socket-security bot commented Sep 25, 2024 •

edited

Loading

ccharly Sep 30, 2024

ccharly Sep 30, 2024

ccharly Sep 30, 2024

ccharly Sep 30, 2024

ccharly left a comment

gantunesr left a comment

gantunesr left a comment

chore: update lint tools versions + use ts 5 #55

chore: update lint tools versions + use ts 5 #55

Conversation

ccharly commented Sep 24, 2024

socket-security bot commented Sep 25, 2024 • edited Loading

ccharly Sep 30, 2024

Choose a reason for hiding this comment

ccharly Sep 30, 2024

Choose a reason for hiding this comment

ccharly Sep 30, 2024

Choose a reason for hiding this comment

ccharly Sep 30, 2024

Choose a reason for hiding this comment

ccharly left a comment

Choose a reason for hiding this comment

gantunesr left a comment

Choose a reason for hiding this comment

gantunesr left a comment

Choose a reason for hiding this comment

socket-security bot commented Sep 25, 2024 •

edited

Loading