[c++] Cast HexDigit argument to int #954
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chwarr
requested changes
Feb 1, 2019
franksinankaya
force-pushed
the
gcc-compile
branch
from
69a4767 to
0a44d05
Compare
Fix implicit conversion error.
bond/cpp/inc/bond/protocol/simple_json_writer.h:201:39: error: call of overloaded ‘HexDigit(unsigned int)’ is ambiguous
u[5] = detail::HexDigit(c >> 0);
^
In file included from bond/cpp/inc/bond/protocol/compact_binary.h:9:0,
from bond/cpp/inc/bond/core/detail/marshaled_bonded.h:8,
from bond/cpp/inc/bond/core/bonded.h:10,
from bond/cpp/inc/bond/core/apply.h:8,
from bond/cpp/inc/bond/core/bond.h:9,
from bond/cpp/inc/bond/core/cmdargs.h:8,
from bond/examples/cpp/core/bf/main.cpp:4:
bond/cpp/inc/bond/protocol/encoding.h:155:13: note: candidate: char bond::detail::HexDigit(int)
inline char HexDigit(int n)
^~~~~~~~
bond/cpp/inc/bond/protocol/encoding.h:161:12: note: candidate: int bond::detail::HexDigit(char)
inline int HexDigit(char c)
^~~~~~~~
Signed-off-by: Sinan Kaya <[email protected]>
franksinankaya
force-pushed
the
gcc-compile
branch
from
0a44d05 to
053d7bb
Compare
franksinankaya
changed the title
|
Time to merge? |
chwarr
approved these changes
Feb 4, 2019
|
In the future, please avoid force pushing when addressing PR feedback: instead just add more commits. We'll squash them when merging. The GitHub UI doesn't yet handle force pushes well during a PR, and it is hard as a reviewer to diff across force pushes. It's gotten better in the past few months, but it's still easy to confuse GitHub. |
chwarr
added a commit
that referenced
this pull request
Feb 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix implicit conversion error.
bond/cpp/inc/bond/protocol/simple_json_writer.h:201:39: error: call of overloaded ‘HexDigit(unsigned int)’ is ambiguous
u[5] = detail::HexDigit(c >> 0);
^
In file included from bond/cpp/inc/bond/protocol/compact_binary.h:9:0,
from bond/cpp/inc/bond/core/detail/marshaled_bonded.h:8,
from bond/cpp/inc/bond/core/bonded.h:10,
from bond/cpp/inc/bond/core/apply.h:8,
from bond/cpp/inc/bond/core/bond.h:9,
from bond/cpp/inc/bond/core/cmdargs.h:8,
from bond/examples/cpp/core/bf/main.cpp:4:
bond/cpp/inc/bond/protocol/encoding.h:155:13: note: candidate: char bond::detail::HexDigit(int)
inline char HexDigit(int n)
^~~~~~~~
bond/cpp/inc/bond/protocol/encoding.h:161:12: note: candidate: int bond::detail::HexDigit(char)
inline int HexDigit(char c)
^~~~~~~~
Signed-off-by: Sinan Kaya [email protected]