Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language-specific Workspace settings leaking into User settings #23118

Closed
chyndman opened this issue Mar 23, 2017 · 1 comment
Closed

Language-specific Workspace settings leaking into User settings #23118

chyndman opened this issue Mar 23, 2017 · 1 comment
Labels
*caused-by-extension Issue identified to be caused by an extension

Comments

@chyndman
Copy link

  • VSCode Version: Code 1.10.2 (8076a19, 2017-03-08T14:02:52.799Z)
  • OS Version: Windows_NT ia32 10.0.14393
  • Extensions:
Extension Author Version
copy-markdown-as-html jerriepelser 1.0.0
cpptools ms-vscode 0.10.5

Steps to Reproduce:

  1. Open Window A in a project without .vscode directory.
  2. Open Window B in a project with .vscode containing language-specific settings.json
  3. Window A will take on those settings in Window B's .vscode as user settings.
@sean-mcmanus
Copy link
Contributor

sean-mcmanus commented Mar 25, 2017

This is a bug with our cpptools extension (introduced in 0.10.5). You can fix it via opening "C:\Users\<user>\.vscode\extensions\ms-vscode.cpptools-0.10.5\out\src\LanguageServer\C_Cpp.js" and changing the lines 174 and 181 to con.update(lang, langConfig);, i.e. removing the "true" which forced the update to occur to the user settings. We'll try to fix this for our next update. You can file a bug at https://github.com/Microsoft/vscode-cpptools/issues if you want.

@rebornix rebornix added the *caused-by-extension Issue identified to be caused by an extension label Mar 27, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*caused-by-extension Issue identified to be caused by an extension
Projects
None yet
Development

No branches or pull requests

3 participants