Creating log file for UWP via GUID #1387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singhsarab
reviewed
Jan 24, 2018
| @@ -64,7 +64,8 @@ public void WriteLine(PlatformTraceLevel level, string message) | |||
| /// <inheritdoc/> | |||
| public bool InitializeVerboseTrace(string customLogFile) | |||
| { | |||
| LogFile = Path.GetTempPath() + Path.GetFileNameWithoutExtension(customLogFile).Replace(" ", "_") + ".TpTrace.log"; | |||
| // Generate log file name using a GUID, as Path.GetFileNameWithoutExtension is throwing exception | |||
There was a problem hiding this comment.
Should we use string operation to get the name ?
This can be a fallback if the above fails, thoughts ?
There was a problem hiding this comment.
I'm waiting for UWP team to come back & tell us why the API GetFileNameWithoutExtension is failing in local machine scenario.
I don't want to write any extra logic till we have to.
Let me know if there are any concerns.
smadala
approved these changes
Jan 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://devdiv.visualstudio.com/DevDiv/VS.in%20Agile%20Testing%20IDE/_workitems?id=555336&_a=edit