Added OutputType to Microsoft.NET.Test.Sdk.target #310
Conversation
| @@ -12,6 +12,13 @@ | |||
|
|
|||
| <Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | |||
|
|
|||
| <PropertyGroup > | |||
| <!-- Output type for full clr test project shoudl be library--> | |||
| <OutputType Condition=" !$(TargetFramework.ToLower().StartsWith('netcoreapp')) ">Library</OutputType> | |||
There was a problem hiding this comment.
How can user override the OutputType if she wishes to?
| <!-- Output type for full clr test project shoudl be library--> | ||
| <OutputType Condition=" !$(TargetFramework.ToLower().StartsWith('netcoreapp')) ">Library</OutputType> | ||
| <!-- Output type for dotnet core test project should be exe. --> | ||
| <OutputType Condition=" $(TargetFramework.ToLower().StartsWith('netcoreapp')) ">Exe</OutputType> |
There was a problem hiding this comment.
Why do we require to have !netcoreapp? Isn't Library the default?
There was a problem hiding this comment.
It is, by default, Library.
The intention behind adding this is to explicitly override the OutputType.
Following scenario can lead to unpredictable behavior if this is not specified.
a. User creates a new netcoreapp1.0 project with current template.
b. User targets the project to net46 as well.
c. User upgraded to latest Microsoft.Net.Test.Sdk package.
c. Since is by default Exe and if we don't override this, net46 tests might not work.
| @@ -12,6 +12,13 @@ | |||
|
|
|||
| <Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | |||
|
|
|||
| <PropertyGroup > | |||
| @@ -12,6 +12,13 @@ | |||
|
|
|||
| <Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | |||
|
|
|||
| <PropertyGroup > | |||
| <!-- Output type for full clr test project shoudl be library--> | |||
| <file src="Microsoft.NET.Test.Sdk.targets" target="build\netcoreapp1.0\" /> | ||
| <file src="Microsoft.NET.Test.Sdk.targets" target="build\net45\" /> | ||
| <file src="Microsoft.NET.Test.Sdk.props" target="build\netcoreapp1.0\" /> | ||
| <file src="Microsoft.NET.Test.Sdk.targets" target="build\netcoreapp1.0\" /> |
There was a problem hiding this comment.
It will break the user with net46 with outputType exe????
There was a problem hiding this comment.
I have reverted it for now, let's have a detailed discussion on this and then do this change later.
Issue Link : #287
Verification done: