Fix empty table header for accessibility #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #355 +/- ##
=======================================
Coverage 89.19% 89.19%
=======================================
Files 21 21
Lines 1222 1222
=======================================
Hits 1090 1090
Misses 132 132
Continue to review full report at Codecov.
|
US Section 508 accessibility standards requires that table headers are appropriately identified: https://webaim.org/standards/508/checklist#standardg
Signed-off-by: OsamaSayegh <[email protected]>
OsamaSayegh
force-pushed
the
empty_thead
branch
from
d9d2eaa to
8683369
Compare
|
Thank you for this PR @bencrouse! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
US Section 508 accessibility standards requires that table headers are appropriately identified: https://webaim.org/standards/508/checklist#standardg
The Wave Extension for accessibility checking calls an empty
theadan "error".I'm not quite sure what the appropriate description is for that column and I'm happy to make any improvements to the words or presentation. Here's what it looks like: