Skip to content
This repository has been archived by the owner on Sep 7, 2020. It is now read-only.

Linter errors in quickstart example #838

Closed
maiertech opened this issue Oct 22, 2016 · 2 comments
Closed

Linter errors in quickstart example #838

maiertech opened this issue Oct 22, 2016 · 2 comments
Labels

Comments

@maiertech
Copy link

I'm using v0.17.11 on Sierra and I'm running this example:

https://phenomic.io/docs/setup/

When I run npm start the site compiles fine and the browser opens as expected. But when I check my terminal I see tons of linter errors like these:

> phenomic start

ℹ Phenomic is starting +0.18s
✔ Development server listening on http://0.0.0.0:3333/ +0.72s
✖ Updated with warnings

⚠ Warning in ./scripts/phenomic.browser.js

./scripts/phenomic.browser.js
  2:1  error  Definition for rule 'react/no-find-dom-node' was not found          react/no-find-dom-node
  2:1  error  Definition for rule 'react/display-name' was not found              react/display-name
  2:1  error  Definition for rule 'react/jsx-no-undef' was not found              react/jsx-no-undef
  2:1  error  Definition for rule 'react/jsx-uses-react' was not found            react/jsx-uses-react

@MoOx
Copy link
Owner

MoOx commented Oct 24, 2016

We found the issue and added a regression test so this won't happen in the future. Thanks for reporting this issue. Please follow #841.

Meanwhile, just replace this

  "eslintConfig": {
    "extends": "./node_modules/phenomic/lib/eslint-config-recommended/index.js"
  },

by this

  "eslintConfig": {
    "plugins": [ "react" ],
    "extends": "./node_modules/phenomic/lib/eslint-config-recommended/index.js"
  },

@MoOx
Copy link
Owner

MoOx commented Oct 25, 2016

Closed by #841, 0.17.12 base theme don't have this issue anymore.

@MoOx MoOx closed this as completed Oct 25, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants