Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dedupe dependencies. #327

Closed
wtgtybhertgeghgtwtg opened this issue Nov 8, 2016 · 12 comments
Closed

Dedupe dependencies. #327

wtgtybhertgeghgtwtg opened this issue Nov 8, 2016 · 12 comments

Comments

@wtgtybhertgeghgtwtg
Copy link

Several of the packages on which postcss-cssnext depends share dependencies (postcss, balanced-match, et cetera). However, since some of them are pinned to difference versions than others, multiple versions of these sub dependencies are downloaded. For [email protected], it looks like four versions of color, three versions of balanced-match, and two versions of each supports-color, postcss-selector-parser, color-string, color-name, and color-convert are required. I am not sure if it is an actionable issue, but could something be done so that these can be deduped?

@MoOx
Copy link
Owner

MoOx commented Nov 8, 2016

I guess one thing to do is to contribute to each dependencies.

@wtgtybhertgeghgtwtg
Copy link
Author

wtgtybhertgeghgtwtg commented Nov 9, 2016

I compiled a list of packages to be updated to dedupe the dependencies.

I will see if they accept PR's for these.

@MoOx
Copy link
Owner

MoOx commented Nov 9, 2016 via email

@MoOx
Copy link
Owner

MoOx commented Nov 28, 2016

I merged the PR you made including this one MoOx/reduce-function-call#5.
I checked some boxes in your previous comment :)

chalk updates for supports-color has landed a while ago. it seems to be in 1.1.2.

@wtgtybhertgeghgtwtg
Copy link
Author

I don't know how I missed that chalk thing.
PR's filed for postcss-selector-not and postcss-custom-properties.

@wtgtybhertgeghgtwtg
Copy link
Author

The latest version ofpostcss-pseudo-class-any-link uses the latest version of postcss-selector-parser, but the minimum supported node version is too high to use.
Not strictly part of this issue, but Nyalab/caniuse-api#54 would also help reduce dependencies.

@MoOx
Copy link
Owner

MoOx commented Jul 5, 2017

@wtgtybhertgeghgtwtg any update on the work done here?

@wtgtybhertgeghgtwtg
Copy link
Author

More duplicates have sprung up. I will compile a list shortly.

@MoOx
Copy link
Owner

MoOx commented Jul 5, 2017

Ouch. Anything to share on how to catch these?

@wtgtybhertgeghgtwtg
Copy link
Author

There's a visualization tool: http://npm.anvaka.com/#/view/2d/postcss-cssnext
The duplicates are supports-color, balanced-match, ansi-styles, has-flag, chalk, postcss, browserslist, color, color-string, and reduce-css-calc.
I think the best way to get some of this out of the way would be to get the packages that still use postcss@5 up to postcss@6. That would be postcss-color-rgba-fallback, postcss-pseudoelements, and pixrem.

@MoOx
Copy link
Owner

MoOx commented Jul 5, 2017

#401 might help... My bad on this...

@MoOx
Copy link
Owner

MoOx commented May 29, 2018

postcss-cssnext has been deprecated in favor of postcss-preset-env. Read more at https://moox.io/blog/deprecating-cssnext/

@MoOx MoOx closed this as completed May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants