Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset paths invalid for symlink packages on metro@^0.47 #14

Open
adrianha opened this issue Oct 11, 2018 · 7 comments
Open

Asset paths invalid for symlink packages on metro@^0.47 #14

adrianha opened this issue Oct 11, 2018 · 7 comments

Comments

@adrianha
Copy link

Hi @MrLoh ,

I got an issue on RN 0.57.2 that asset paths from symlink packages cannot be resolved correctly. I think its related to this issue

Here's the repo to reproduce this issue:
https://github.com/adrianha/metro-symlink - Works fine
react-native: 0.57.1

https://github.com/adrianha/metro-symlink/tree/0.57.2 - Assets path incorrect
react-native: 0.57.2

Any suggestion?

@treyp
Copy link
Collaborator

treyp commented Oct 11, 2018

I suspect this is an issue in metro and can't be fixed using metro options. The only relevant options are around asset transformation and I think configuring those will suffer from the same issue since there doesn't seem to be a granular way to configure the httpServerLocation.

@MrLoh
Copy link
Owner

MrLoh commented Oct 12, 2018

I’m not on RN 0.57 yet, so can’t say much. I’ll check once we upgrade, but it might still take a while. Sorry

@6pm
Copy link

6pm commented Jan 21, 2019

rn-cli.config.js was renamed to metro.config.js

@MrLoh
Copy link
Owner

MrLoh commented Apr 22, 2019

@treyp can you confirm that your this was fixed in #18?

@treyp
Copy link
Collaborator

treyp commented Apr 23, 2019

yep, symlinks are working fine for me again. i'm using [email protected] with [email protected] (just published).

i'd suggest trying RN >= 0.59. they were broken for me in 0.57.2 and 0.58.

@MrLoh MrLoh closed this as completed Apr 23, 2019
@treyp
Copy link
Collaborator

treyp commented May 20, 2019

Sorry, that comment was based on my usage of RN 0.59 in iOS only.

I've tried using Android and the issue still exists there. However, I don't think it's something that can be solved with metro config options, so I don't see a path forward for this repo.

Best thing I can suggest is to monitor facebook/metro#290

@MrLoh
Copy link
Owner

MrLoh commented May 20, 2019

I'm reopening this for transparency then, since it's not fully solved yet.

@MrLoh MrLoh reopened this May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants