Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Morning session : Code review #5

Open
wassimchakib opened this issue Nov 24, 2022 · 0 comments
Open

Morning session : Code review #5

wassimchakib opened this issue Nov 24, 2022 · 0 comments

Comments

@wassimchakib
Copy link

Morning Code Review: ⏰

Congratulations Mujeeb on your code, it looks fantastic but here are some change to make your project outstanding:

thumb-up

  • You can use form.reset() instead of giving your inputs an empty strings in your index.js file
  • For the best practice, don't force user to consume API when refreshing the page. Instead you can disable loading the result when refreshing the page and give user the freedom to consume it whenever he/she wants
  • Try to secure your API by using .env file
  • Try to show the message when the input fields are empty
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant