Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kanban for React Group project #25

Open
Mujeeb4582 opened this issue Dec 19, 2022 · 3 comments
Open

Kanban for React Group project #25

Mujeeb4582 opened this issue Dec 19, 2022 · 3 comments

Comments

@Mujeeb4582
Copy link
Owner

Task completed

  • Add the react Kanban template to repo.
  • Assign the card to code partners.
  • Link of Kanban

Note:

  • We are two members in the group.
@mckent05
Copy link

Hi @Mujeeb4582,

STATUS: CHANGES REQUIRED ♻️ ♻️

Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
almost there

Highlights

  • Good job setting up your Kanban board nicely ✔️
  • You did well including a link to your Kanban in your issue 👏 👏

Required Changes ♻️

  • According to the project requirements, each student should have cards with all required categories in their titles, this card and this card have been assigned to the same person, please fix this
    Check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@Mujeeb4582
Copy link
Owner Author

Reassign the card according to the requirement

  • Fix the problem by reassigning the card
    this card and this card have been assigned to the different person

@jerryowusu
Copy link

Hi Team ,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

200w

Highlights

Good job setting up your Kanban board ✔️
Excellent working for making the required changes. ✔️

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants