Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some kind of fallback/error message when we cannot connect to the API #153

Closed
itssimple opened this issue Feb 28, 2018 · 0 comments · Fixed by #534
Closed

Add some kind of fallback/error message when we cannot connect to the API #153

itssimple opened this issue Feb 28, 2018 · 0 comments · Fixed by #534
Assignees
@itssimple
Labels
enhancement never-stale Issues/PRs that should never be marked/close as stale

Comments

@itssimple
Copy link
Member

itssimple commented Feb 28, 2018 •
edited
Loading

We should be able to provide an error page when we have (scheduled/unexpected) downtime.

(or when the customers' account has been terminated, i.e. missing payment on invoices)
@itssimple itssimple added the never-stale Issues/PRs that should never be marked/close as stale label Sep 5, 2023
@itssimple itssimple self-assigned this Nov 4, 2024
itssimple added a commit that referenced this issue Nov 5, 2024
@itssimple
feat: Handle API being down/blocked, instead of making the site hang …
a1a5104 
…until the configured timeout happens.

We now have a configured timeout for the API client as the following:
- Connection timeout: 0.5 seconds at most
- Response timeout: 5 seconds at most (yes, if the API is slow, we will consider it down)

And in the plugin, we have also implemented a check that has a timeout of 0.25 seconds (but always goes for 1 second anyway for some reason), and if we decide that the API is not responding fast enough, a warning saying that the plugin cannot connect to the API will be shown.

In the admin pages, an error will be shown, with the suggestion to contact the EduAdmin Support for help.

Fixed another possible injection in template variables in course list view.

fixes #153
@itssimple itssimple mentioned this issue Nov 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@itssimple itssimple

Labels
enhancement never-stale Issues/PRs that should never be marked/close as stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v5.3.0 MultinetInteractive/eduadmin-booking
1 participant
@itssimple