Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/release aiml updates #95

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Feat/release aiml updates #95

wants to merge 10 commits into from

Conversation

Mohith93
Copy link
Contributor

Documentation Updates

Updated release documentation until May 2024

AI ML Sources documentation

@Mohith93
Copy link
Contributor Author

Mohith93 commented Sep 2, 2024

Screenshot 2024-08-30 at 10 04 25 PM Screenshot 2024-08-30 at 10 04 37 PM Screenshot 2024-08-30 at 10 04 51 PM

@Mohith93
Copy link
Contributor Author

Mohith93 commented Sep 2, 2024

image

@macintushar
Copy link
Member

NIT: should be AI/ML and not AI & ML IMO

guides/ai-ml-integration/Sources.mdx Outdated Show resolved Hide resolved
guides/ai-ml-integration/Sources.mdx Outdated Show resolved Hide resolved
release-notes/June_2024.mdx Outdated Show resolved Hide resolved
Comment on lines +36 to +51
To establish a connection to your chosen endpoint, fill in the following details:
<ul>
<li><strong>Endpoint Name:</strong> A unique name to identify this endpoint.</li>
<li><strong>URL:</strong> The endpoint's URL where the data can be accessed.</li>
<li><strong>Authentication:</strong> Select the type of authentication required for accessing the endpoint.</li>
<li><strong>Auth Header:</strong> Provide the authentication header if needed.</li>
<li><strong>Secret Key:</strong> Enter the secret key for secure access.</li>
</ul>
Additionally, provide a sample <strong>Request Format</strong> and <strong>Response Format</strong> to define how data will be sent to and received from the endpoint.
<img
className="block"
src="https://res.cloudinary.com/dspflukeu/image/upload/f_auto,q_auto/v1/DevRel/Source%20-%20AIML/step3"
alt="Step 3"
/>
</Step>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be updated.

Go to production and see the config screen for Databricks AI Model.
The designs are different


<Step title="Step 4">
After entering the necessary details, test the connection by clicking on the <strong>Test Connection</strong> button. Ensure that you receive a "Connection Successful" response, indicating that the endpoint is correctly configured.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no Test Connection button. The image you attached and text you have written does not align well.
On this screen, it automatically starts testing the config and updates you

---
**Conclusion:**
Once the source is created, it will be displayed in the **Sources** list with a tag labeled **AI/ML** to easily differentiate it from other types of sources.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong.
There will no tag.

Sources screen has AIML Sources and Data Sources which helps in differentiating the Sources.
Please update this

@subintp
Copy link
Collaborator

subintp commented Sep 17, 2024

/add_docs

@subintp
Copy link
Collaborator

subintp commented Sep 17, 2024

/improve

Copy link

codiumai-pr-agent-pro bot commented Sep 17, 2024

The docstring command only supports the following languages: python, java, cpp, javascript, typescript, jsx, tsx, csharp

Copy link

codiumai-pr-agent-pro bot commented Sep 17, 2024

PR Code Suggestions ✨

CategorySuggestion                                                                                                                                    Score
Accessibility
Improve image accessibility by providing a more descriptive alt text

Consider adding a more descriptive alt text for the image. Instead of "Hero Light",
use a description that explains what the image represents in the context of Data
Apps.

guides/ai-ml-integration/Data_Apps.mdx [7-11]

 <img
   className="block"
   src="https://res.cloudinary.com/dspflukeu/image/upload/f_auto,q_auto/v1/DevRel/dataapps"
-  alt="Hero Light"
+  alt="Data Apps integration illustration"
 />
 
  • Apply this suggestion
Suggestion importance[1-10]: 8

Why: The suggestion improves accessibility by providing a more descriptive alt text, which is important for users relying on screen readers to understand the content of images.

8
Enhancement
Add a brief introduction before the step-by-step guide

Consider adding a brief introduction or summary before the Steps component to
provide context for the process of connecting AI/ML sources.

guides/ai-ml-integration/Sources.mdx [9-16]

 <img
   className="block"
   src="https://res.cloudinary.com/dspflukeu/image/upload/f_auto,q_auto/v1/DevRel/sources"
   alt="Source Image"
 />
 
+To connect your AI/ML sources to the AI Squared application, follow these steps:
+
 <Steps>
 
  • Apply this suggestion
Suggestion importance[1-10]: 7

Why: Adding an introduction provides context and enhances the readability of the document, making it easier for users to understand the purpose of the steps.

7
Add version numbers to features and improvements for better change tracking

Consider adding version numbers for each feature and improvement to provide more
context and make it easier for users to track changes.

release-notes/June_2024.mdx [8-17]

 # 🚀 Features
 
-- **Iterable Destination Connector**  
+- **Iterable Destination Connector** (v0.12.0)  
   Integrate with Iterable, allowing seamless data flow to this popular marketing automation platform.
 
-- **Workspace Settings and useQueryWrapper**  
+- **Workspace Settings and useQueryWrapper** (v0.12.1)  
   New enhancements to workspace settings and the introduction of `useQueryWrapper` for improved data handling.
 
-- **Amazon S3 Source Connector**  
+- **Amazon S3 Source Connector** (v0.13.0)  
   Added support for Amazon S3 as a source connector, enabling data ingestion directly from your S3 buckets.
 
  • Apply this suggestion
Suggestion importance[1-10]: 6

Why: Including version numbers helps users track changes more effectively, although it is not crucial for understanding the release notes.

6
Maintainability
Reorganize features into logical groups for improved readability

Consider grouping related features and improvements together to make the release
notes more organized and easier to read.

release-notes/May_2024.mdx [8-27]

 # 🚀 Features
 
+## Connectors and Integrations
+- **Zendesk Destination Connector**  
+  Added support for Zendesk as a destination connector, enabling seamless integration with Zendesk for data flow.
+- **Athena Connector**  
+  Integrated the Athena Connector, allowing users to connect to and query Athena directly from the platform.
+- **HTTP Destination Connector**  
+  Introduced the HTTP Destination Connector, allowing data to be sent to any HTTP endpoint.
+
+## Platform Enhancements
 - **Role and Resource Migration**  
   Introduced migration capabilities for roles and resources, enhancing data management and security.
-
-- **Zendesk Destination Connector**  
-  Added support for Zendesk as a destination connector, enabling seamless integration with Zendesk for data flow.
-
-- **Athena Connector**  
-  Integrated the Athena Connector, allowing users to connect to and query Athena directly from the platform.
-
 - **Support for Temporal Cloud**  
   Enabled support for Temporal Cloud, facilitating advanced workflow orchestration in the cloud.
-
 - **Workspace APIs for CE**  
   Added Workspace APIs for the Community Edition, expanding workspace management capabilities.
 
-- **HTTP Destination Connector**  
-  Introduced the HTTP Destination Connector, allowing data to be sent to any HTTP endpoint.
-
  • Apply this suggestion
Suggestion importance[1-10]: 5

Why: Grouping related features enhances the organization and readability of the release notes, though it is not essential for understanding the content.

5

@subintp
Copy link
Collaborator

subintp commented Sep 17, 2024

/review

Copy link

PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
🧪 No relevant tests
🔒 Security concerns

Sensitive information exposure:
The PR includes placeholders for authentication headers and secret keys in the 'guides/ai-ml-integration/Sources.mdx' file. While these are likely just placeholders, it's important to ensure that no actual sensitive information is accidentally committed. It's recommended to use environment variables or secure secret management systems for handling such sensitive data in production.

⚡ Key issues to review

Sensitive Information Exposure
The code includes placeholders for sensitive information such as authentication headers and secret keys. Ensure these are not accidentally committed with real values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants